- 
                Notifications
    You must be signed in to change notification settings 
- Fork 349
docs(contribution): added extra information on the contributing page from the KICS documentation #7749
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left some comments to improve the text, minimal but quality changes 😃
Co-authored-by: Artur Ribeiro <[email protected]>
Co-authored-by: Artur Ribeiro <[email protected]>
Co-authored-by: Artur Ribeiro <[email protected]>
Co-authored-by: Artur Ribeiro <[email protected]>
Co-authored-by: Artur Ribeiro <[email protected]>
Co-authored-by: Artur Ribeiro <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just 2 typo fixes 😅
All good to me after that.
Co-authored-by: Artur Ribeiro <[email protected]>
Co-authored-by: Artur Ribeiro <[email protected]>
…om/Checkmarx/kics into task-contribution-page-open-source
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM








Closes #
Reason for Proposed Changes
Proposed Changes
Get Started!, added a note, mentioning that if the changes made cause the KICS pipeline to fail, the community can follow the steps outlined in the newTipssection.Tipssection covers the following cases:go.modfile). It is also mentioned that this is not the only case for the failures regarding the Grype or Trivy tests, and a change on thegoandgitimages on the Dockerfile sometimes will be needed(just informing, because it's the teams that are responsible for changing that), or it could be a different case.-timeoutto extend the time that the E2E tests spend running. (e.g.,-timeout 60m).I submit this contribution under the Apache-2.0 license.