Skip to content

Conversation

robin-checkmk
Copy link
Member

@robin-checkmk robin-checkmk commented May 28, 2025

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: #646

What is the new behavior?

  • Add module for DCD
  • Add modules for BI
  • Extend authentication

Other information

We would like to thank Atruvia AG for their gratious code donation!
Their willingness to share their internal code with us served as a basis for the content added with this PR.
Thanks a lot!
(does not seem to have the customer attribute)

ToDo

  • Make modules Python 2.7 and 3.5 (see failing sanity tests)
  • Double-check docs
  • Create integration tests for all modules
    • bi_pack
    • bi_rule
    • bi_aggregation
    • dcd
    • Enable all Sites for integration tests
  • Make modules 2.4.0-ready
    • bi_pack
    • bi_rule
    • bi_aggregation
    • dcd
  • Make modules CME-ready
    • bi_pack (does not seem to have the customer attribute)
    • bi_rule (does not seem to have the customer attribute)
    • bi_aggregation
    • dcd
  • bi_rule module:
    • params is required by the REST API this makes no sense, but will also not be fixed soon, so we need either a workaround or documentation
  • Check if differ.py can be moved into utils.py.
  • Check if ExtendedCheckmkAPI can become part of CheckmkAPI (in apy.py).
  • Check copyright headers and CODEOWNERS
  • Discuss new auth mechanisms
  • Add tests (unit/integration?) for new auth mechanisms

@robin-checkmk robin-checkmk self-assigned this May 28, 2025
@robin-checkmk robin-checkmk force-pushed the features-atruvia-dcd-bi branch from 90990e6 to 4972473 Compare May 28, 2025 15:56
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Jun 3, 2025
@github-actions github-actions bot added role:server This affects the server role role:agent This affects the agent role labels Jun 25, 2025
@robin-checkmk robin-checkmk force-pushed the features-atruvia-dcd-bi branch from f826c6e to 69c0d1c Compare June 26, 2025 08:48
@robin-checkmk robin-checkmk force-pushed the features-atruvia-dcd-bi branch from 69c0d1c to d15e6f6 Compare July 7, 2025 09:20
@robin-checkmk robin-checkmk force-pushed the devel branch 2 times, most recently from 1759ef1 to a5cce61 Compare September 1, 2025 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation role:agent This affects the agent role role:server This affects the server role
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant