Skip to content

Andj #76

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: integ_2024
Choose a base branch
from
Open

Andj #76

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
cba8b5a
testing
Nov 7, 2024
a1172d2
testing
Nov 7, 2024
48488c0
testing
Nov 7, 2024
482204d
test
Nov 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion connector/ldap/ldap.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,11 +7,12 @@ import (
"crypto/x509"
"encoding/json"
"fmt"
"github.com/go-ldap/ldap/v3"
"net"
"os"
"strings"

"github.com/go-ldap/ldap/v3"

"github.com/dexidp/dex/connector"
"github.com/dexidp/dex/pkg/log"
)
Expand Down Expand Up @@ -706,6 +707,10 @@ func (c *ldapConnector) queryGroups(ctx context.Context, memberAttr string, dn s
req.BaseDN, scopeString(req.Scope), req.Filter)
resp, err := conn.Search(req)
if err != nil {
if ldapErr, ok := err.(*ldap.Error); ok && ldapErr.ResultCode == ldap.LDAPResultNoSuchObject {
c.logger.Infof("ldap: groups search with filter %q returned no groups", filter)
return nil
}
return fmt.Errorf("ldap: search failed: %v", err)
}
groups = append(groups, resp.Entries...)
Expand Down