Skip to content

Changes to support Multiple AssertionConsumerServiceURLs #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 18 commits into
base: master
Choose a base branch
from
Open

Changes to support Multiple AssertionConsumerServiceURLs #3

wants to merge 18 commits into from

Conversation

@anuviswa
Copy link

@anuviswa anuviswa commented Sep 14, 2022 •
edited
Loading

Made the following changes to support SSO login from multiple assertion consumer urls.

  1. Added a field called MultiAssertionConsumerServiceURLs to the SAMLServiceProvider
  2. Generate indexed ACS urls in the metadata based on this field.
  3. If more than one ACS URL is configured, allow the SAML response destination and recipient matching with any one of the ACS url specified in the SAMLServiceProvider.

ANURAGINI VISWANATHAN (anuviswa) added 16 commits May 10, 2022 15:18
Adding multinode audience URI to specify all three nodes of an inters…
4c3b50c 
…ight appliance as audience for SSO login.
Adding logs for debug purposes.
3951924
Adding the go mod file.
10de3f8
Deleted go.mod file
5acc2bb
Adding support to specify multiple ACS URLs for a SAML SP.
492f497
Adding multi ACS URL support for MetaDataWithSLO as well.
4e0f574
Adding the acsUrl as an optional parameter for the buildAuthnRequest …
6d0e57e 
…to use if not empty.
Recognize any valid acsUrl of a multinode system specified in the SP.
a636b3b
Fixing the typo for ACS URL.
f4218b7
Fixing typo.
a56fa5d
Allow any recipient which matches one of the acsUrls specified in the…
9e05851 
… SP metadata.
Added logs for debugging.
07ae387
Keeping the entity id fixed and removing the multi audience check and…
636b3ba 
… code cleanup.
Do recipient and destination matching for both single and multiple AC…
0c895bb 
…S url cases.
Fixing typo.
e10018e
Adding empty destination case for multi acs url similar to single acs…
83deaf3 
… url.
@sebastien-rosset
Copy link

Please add unit tests.

@sebastien-rosset sebastien-rosset self-requested a review September 14, 2022 19:07
sebastien-rosset
sebastien-rosset suggested changes Sep 14, 2022
View reviewed changes
Copy link

@sebastien-rosset sebastien-rosset left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add unit tests

@sebastien-rosset
Copy link

We should sync the fork from upstream.

anuviswa added a commit that referenced this pull request Sep 21, 2022
@anuviswa
Merge pull request #7 from CiscoM31/multiacs
a19fc26 
Changes to support Multiple AssertionConsumerServiceURLs #3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@sebastien-rosset sebastien-rosset sebastien-rosset requested changes

@kumarkowsikt kumarkowsikt kumarkowsikt approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@anuviswa @sebastien-rosset @kumarkowsikt