-
Notifications
You must be signed in to change notification settings - Fork 2
Update download link and remove unnecessary cell #17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Update download link and remove unnecessary cell #17
Conversation
sanika-vaze
commented
Jul 30, 2025
- 03 Data Acquisition Notebook: Updated Download link for Credit Suisse Global Wealth Datebook (GWDB) -- old link didn't work anymore
- 01 Data Cleaning Notebook: Removed Mangroves Cell because this modified version is not used anywhere/ unnecessary
…otebook and Removed unecessary cell (mangroves) in 01 Data Cleaning Notebook
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
03 notebook looks good but looks like the 01 notebook does not have the intended changes
{ | ||
"cell_type": "markdown", | ||
"id": "dbff1f30-3dd4-4666-9df2-5358f456f5eb", | ||
"id": "3207b1e9-62fd-43b1-8265-a923d4ab8eb7", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like the same changes made in #16 (moving the GADM cell) are repeated in this PR, and I don't see the removal of the mangroves section.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
check link in GWDB download
" \"PS9jb250ZW50L2RhbS9hc3NldHMvd20vZ2xvYmFsL2ltZy9nbG9iYWwtZmFtaWx5LW9mZmljZS\"\n", | ||
" \"9kb2NzL2RhdGFib29rLWdsb2JhbC13ZWFsdGgtcmVwb3J0LTIwMjMtZW4ucGRm/\"\n", | ||
" \"databook-global-wealth-report-2023-en.pdf\"\n", | ||
" \"https://urldefense.us/v3/__https:/www.ubs.com/global/en/family-office-uhnw/reports/global-wealth-report-2023/_jcr_content/mainpar/toplevelgrid_5684475_1708633751/col1/innergrid/xcol1/actionbutton_copy_co.1784379955.file/PS9jb250ZW50L2RhbS9hc3NldHMvd20vZ2xvYmFsL2ltZy9nbG9iYWwtZmFtaWx5LW9mZmljZS9kb2NzL2d3ci0yMDIzLWVuLTIucGRm/gwr-2023-en-2.pdf__;!!PvBDto6Hs4WbVuu7!LkcjRnpeJpav7n7pccnu9GARkLWeYSdBrUR7_2wbXi9tKQiH0E3ypwI9h8cm0uHmnY0eFJ3da07dQQScVsUHry39Hg$\"\n", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just checked this link and it looks like it's not correct - sorry for sending you the wrong one. If you use this link, you'd see that it goes to the "report" rather than the "databook". Here's a link to the databook:
https://rev01ution.red/wp-content/uploads/2024/03/global-wealth-databook-2023-ubs.pdf
Also, the "urldefense" part of the URL is just something that comes through on email clients so can be removed. But let's use the link above, otherwise it will be downloading the wrong thing (which is why you didn't see Table 2-1 or Table 2-2 when you looked at it)
Also note that git is seeing some conflicts with the main branch. This likely means that you branched off of something other than the latest commit on the main branch, so you'll need to resolve these comments (rebasing onto the main branch would be my recommendation) before it will let us merge. |