[crmsh-4.6] support crm cluster copy to copy directory #1911
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
Additional details and impacted files
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
liangxin1300
force-pushed
the
20250905_copy_directory
branch
from
393715b to
edf6dc7
Compare
liangxin1300
changed the title
…mkdir on remote - Resolve local_path to absolute if necessary. - Check existence of local_path before operation. - Determine whether to copy recursively based on path type. - Use Pathlib for safe path operations. - Pre-create target directory on remote nodes using 'test -d ... || mkdir -p ...'.
liangxin1300
force-pushed
the
20250905_copy_directory
branch
from
edf6dc7 to
40fb852
Compare
| source_path = local_path | ||
| parent_path = p.parent | ||
| else: | ||
| absolute_path = p.resolve() |
There was a problem hiding this comment.
When p is a symlink /foo/link -> /bar, should we copy the symlink /foo/link or the link target /bar?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partly backport from #1824:
crm cluster copy#1909