Skip to content

Conversation

@liangxin1300
Copy link
Collaborator

Raise ValueError if the timeout value is less than the minimum allowed value.

Backport from #1944

@liangxin1300 liangxin1300 marked this pull request as draft October 16, 2025 14:18
@codecov
Copy link

codecov bot commented Oct 16, 2025

Codecov Report

❌ Patch coverage is 88.88889% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 70.76%. Comparing base (2ee7704) to head (0461c78).
⚠️ Report is 1 commits behind head on crmsh-5.0.

Files with missing lines Patch % Lines
crmsh/ui_sbd.py 88.88% 1 Missing ⚠️
Additional details and impacted files
Flag Coverage Δ
integration 55.21% <22.22%> (-0.01%) ⬇️
unit 52.95% <88.88%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
crmsh/ui_sbd.py 84.64% <88.88%> (-0.12%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@liangxin1300 liangxin1300 marked this pull request as ready for review October 17, 2025 02:50
Raise ValueError if the timeout value is less than the minimum allowed
value.
@liangxin1300 liangxin1300 force-pushed the 20251016_prevent_invalid_sbd_timeout_setting_crmsh50 branch from 0461c78 to bc295e0 Compare October 17, 2025 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant