chore: update protobuf and abseil #957
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonresch
force-pushed
the
update-protobuf
branch
2 times, most recently
from
f8edf4f to
2ce461a
Compare
Using the full original factory to construct a mutator for protobuf enum types would trigger a deeply nested mutator construction attempt on the EnumValueDescriptor class using e.g. the `CachedConstructorMutatorFactory`. While this still ended up at the dedicated enum mutator for most cases, for complex protobuf parameters it could lead to the construction of invalid mutators. At the point where an enum type is reached we now use a simplified factory instead that only deals with repeated or nullable enums.
Recent versions of googletest require C++17 to compile.
simonresch
force-pushed
the
update-protobuf
branch
from
2ce461a to
0e762a8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.