-
Notifications
You must be signed in to change notification settings - Fork 162
fix: correct method descriptors #967
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
c7f252d
to
2ccf382
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds a comprehensive test to validate that all @MethodHook
annotations in sanitizers reference existing classes and methods, while also fixing several typos and descriptor errors discovered by this validation.
- Introduces
HookBindingSanityTest
to verify method hook annotations reference valid targets - Fixes multiple typos in method descriptors across sanitizer classes
- Corrects class name references and removes duplicate/invalid hooks
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.
Show a summary per file
File | Description |
---|---|
HookBindingSanityTest.java | New test class that validates method hook annotations against actual class/method existence |
BUILD.bazel (test) | Adds build configuration for the new test with required dependencies |
RegexRoadblocks.java | Fixes return type in method descriptor from CharPredicate to BmpCharPredicate |
LdapInjection.kt | Corrects typos in method descriptors (namespace separator and parameter type) |
FilePathTraversal.java | Fixes class name typo and removes duplicate method hook |
BUILD.bazel (main) | Updates visibility to allow test access to sanitizer classes |
maven_install.json | Adds new Maven dependencies required for testing |
MODULE.bazel | Declares new Maven artifacts for Jakarta EL and JPA APIs |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
sanitizers/src/test/java/com/code_intelligence/jazzer/sanitizers/HookBindingSanityTest.java
Outdated
Show resolved
Hide resolved
sanitizers/src/test/java/com/code_intelligence/jazzer/sanitizers/HookBindingSanityTest.java
Outdated
Show resolved
Hide resolved
8511bfa
to
909680c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome work, especially with the tests!
sanitizers/src/test/java/com/code_intelligence/jazzer/sanitizers/HookBindingSanityTest.java
Outdated
Show resolved
Hide resolved
sanitizers/src/test/java/com/code_intelligence/jazzer/sanitizers/HookBindingSanityTest.java
Outdated
Show resolved
Hide resolved
909680c
to
b45d2eb
Compare
Adds a test to check that
MethodHook
annotations in sanitizers reference existing classes & methods.