Skip to content

Fix menu-open class handling on treeview #5888

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Fix menu-open class handling on treeview #5888

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3a7c4f6
Fix menu-open class handling on treeview
dfsmania Aug 1, 2025
b705a20
Fix event dispatching on treeview
dfsmania Aug 1, 2025
50f40f8
Rework the entire fix by avoiding treeview instances on link items
dfsmania Aug 1, 2025
7e51eb0
Revert changes to minimize diff
dfsmania Aug 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/ts/treeview.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,8 +119,14 @@ onDOMContentLoaded(() => {
const target = event.target as HTMLElement
const targetItem = target.closest(SELECTOR_NAV_ITEM) as HTMLElement | undefined
const targetLink = target.closest(SELECTOR_NAV_LINK) as HTMLAnchorElement | undefined
const targetTreeviewMenu = targetItem?.querySelector(SELECTOR_TREEVIEW_MENU) as HTMLElement | undefined
const lteToggleElement = event.currentTarget as HTMLElement

// Avoid creating Treeview instances on non menu elements
if (!targetTreeviewMenu) {
return
}

if (target?.getAttribute('href') === '#' || targetLink?.getAttribute('href') === '#') {
event.preventDefault()
}
Expand Down
Loading