-
Notifications
You must be signed in to change notification settings - Fork 406
fix(AssetCard): use tooltip instead of title for overflow text #6556
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🎨 Storybook Build Status✅ Build completed successfully! ⏰ Completed at: 11/03/2025, 07:47:24 PM UTC 🔗 Links🎉 Your Storybook is ready for review! |
🎭 Playwright Test Results⏰ Completed at: 11/03/2025, 08:03:19 PM UTC 📈 Summary
📊 Test Reports by Browser
🎉 Click on the links above to view detailed test results for each browser configuration. |
fe96b55 to
91fdbb8
Compare
Bundle Size ReportSummary
Category Glance Per-category breakdownApp Entry Points — 3.27 MB (baseline 3.27 MB) • 🔴 +736 BMain entry bundles and manifests
Status: 3 added / 3 removed Graph Workspace — 728 kB (baseline 728 kB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration
Status: 1 added / 1 removed Views & Navigation — 8.18 kB (baseline 8.18 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces
Status: 1 added / 1 removed Panels & Settings — 293 kB (baseline 293 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens
Status: 6 added / 6 removed UI Components — 12.6 kB (baseline 12.6 kB) • ⚪ 0 BReusable component library chunks
Status: 1 added / 1 removed Data & Services — 10.4 kB (baseline 10.4 kB) • ⚪ 0 BStores, services, APIs, and repositories
Status: 1 added / 1 removed Utilities & Hooks — 1.07 kB (baseline 1.07 kB) • ⚪ 0 BHelpers, composables, and utility bundles
Vendor & Third-Party — 5.32 MB (baseline 5.32 MB) • ⚪ 0 BExternal libraries and shared vendor chunks
Other — 2.55 MB (baseline 2.55 MB) • ⚪ 0 BBundles that do not match a named category
|
## Summary The default `title` attribute was too small and too slow to show for users. We were getting complaints about not being able to see the full name of the model. Using [Prime Vue's tooltip](https://primevue.org/tooltip) instead. ## Screenshots (if applicable) Before: <img width="480" height="246" alt="image" src="https://github.com/user-attachments/assets/db4d1cc7-9e9a-40b3-bf16-57f2def93726" /> After: <img width="518" height="720" alt="image" src="https://github.com/user-attachments/assets/500389e5-c781-4d3b-b62e-1e72d2b7e2c6" /> ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-6556-fix-AssetCard-use-tooltip-instead-of-title-for-overflow-text-2a06d73d365081939dc0d863b05f1e90) by [Unito](https://www.unito.io)
|
@arjansingh Successfully backported to #6558 |
## Summary The default `title` attribute was too small and too slow to show for users. We were getting complaints about not being able to see the full name of the model. Using [Prime Vue's tooltip](https://primevue.org/tooltip) instead. ## Screenshots (if applicable) Before: <img width="480" height="246" alt="image" src="https://github.com/user-attachments/assets/db4d1cc7-9e9a-40b3-bf16-57f2def93726" /> After: <img width="518" height="720" alt="image" src="https://github.com/user-attachments/assets/500389e5-c781-4d3b-b62e-1e72d2b7e2c6" /> ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-6556-fix-AssetCard-use-tooltip-instead-of-title-for-overflow-text-2a06d73d365081939dc0d863b05f1e90) by [Unito](https://www.unito.io)
…verflow text (#6558) Backport of #6556 to `rh-test` Automatically created by backport workflow. ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-6558-backport-rh-test-fix-AssetCard-use-tooltip-instead-of-title-for-overflow-text-2a06d73d365081bd8e12dea668538935) by [Unito](https://www.unito.io) Co-authored-by: Arjan Singh <[email protected]>
Summary
The default
titleattribute was too small and too slow to show for users. We were getting complaints about not being able to see the full name of the model.Using Prime Vue's tooltip instead.
Screenshots (if applicable)
Before:
After:
┆Issue is synchronized with this Notion page by Unito