Hide browser tab star when autosave is enabled #6568
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…logic for readability
dosubot
bot
added
the
size:S
🎭 Playwright Test Results⏰ Completed at: 11/04/2025, 04:35:07 AM UTC 📈 Summary
📊 Test Reports by Browser
🎉 Click on the links above to view detailed test results for each browser configuration. |
🎨 Storybook Build Status✅ Build completed successfully! ⏰ Completed at: 11/04/2025, 04:18:43 AM UTC 🔗 Links🎉 Your Storybook is ready for review! |
benceruleanlu
changed the title
Bundle Size ReportSummary
Category Glance Per-category breakdownApp Entry Points — 3.28 MB (baseline 3.28 MB) • ⚪ 0 BMain entry bundles and manifests
Status: 3 added / 3 removed Graph Workspace — 728 kB (baseline 728 kB) • 🔴 +596 BGraph editor runtime, canvas, workflow orchestration
Status: 1 added / 1 removed Views & Navigation — 8.18 kB (baseline 8.18 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces
Status: 1 added / 1 removed Panels & Settings — 293 kB (baseline 293 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens
Status: 6 added / 6 removed UI Components — 12.6 kB (baseline 12.6 kB) • ⚪ 0 BReusable component library chunks
Status: 1 added / 1 removed Data & Services — 10.4 kB (baseline 10.4 kB) • ⚪ 0 BStores, services, APIs, and repositories
Status: 1 added / 1 removed Utilities & Hooks — 1.07 kB (baseline 1.07 kB) • ⚪ 0 BHelpers, composables, and utility bundles
Vendor & Third-Party — 5.32 MB (baseline 5.32 MB) • ⚪ 0 BExternal libraries and shared vendor chunks
Other — 2.55 MB (baseline 2.55 MB) • ⚪ 0 BBundles that do not match a named category
|
…mposable with effectScope
dosubot
bot
added
size:M
| ) | ||
|
|
||
| const isAutoSaveEnabled = computed( | ||
| () => settingStore.get('Comfy.Workflow.AutoSave') === 'after delay' |
Contributor
There was a problem hiding this comment.
nit: we could make the 'after delay' a shared enum or we could try typing settingStore.get<settings['Comfy.Workflow.AutoSave']>(). (so that if this changes in the future, a type error will occur.)
christian-byrne
approved these changes
Nov 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
shouldShowUnsavedIndicator,isActiveWorkflowModified,isActiveWorkflowPersisted).Files touched:
Validation:
pnpm lint:fixandpnpm typecheck— both passed.Manual test suggestions:
*.*.┆Issue is synchronized with this Notion page by Unito