[backport rh-test] Fix cloud routing issues caused by incorrect api_base calculation #6578
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
) ## Summary - Resolves multiple cloud environment issues when accessing `/cloud/user-check` directly - Fixes API routing problems that caused 304 Not Modified errors and JSON parsing failures - Maintains compatibility with subpath deployments for OSS users ## Root Cause The `api_base` was incorrectly calculated as `/cloud` on cloud SPA routes, causing API calls to use wrong paths like `/cloud/api/user` instead of `/api/user`. ## Issues Fixed - ❌ `/cloud/user-check` direct access resulted in infinite loading - ❌ JSON parsing errors: `Unexpected token '<', "<!DOCTYPE "... is not valid JSON` - ❌ 304 Not Modified responses on `/cloud/api/user`, `/cloud/api/settings/onboarding_survey`, `/cloud/api/system_stats` ## Solution Added conditional `api_base` calculation in `ComfyApi` constructor: - **Cloud SPA routes** (`/cloud/*`): Use empty `api_base` → API calls use `/api/*` paths - **Regular deployments**: Keep existing logic → Supports subpath deployments ## Test Plan - [x] Verify `/cloud/user-check` direct access works without infinite loading - [x] Verify all API calls return 200 instead of 304 - [x] Verify OSS subpath deployment compatibility unchanged - [x] Test authentication flow completion 🤖 Generated with [Claude Code](https://claude.ai/code) ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-6572-Fix-cloud-routing-issues-caused-by-incorrect-api_base-calculation-2a16d73d36508163aeb2cbf6347b427d) by [Unito](https://www.unito.io)
4 tasks
dosubot
bot
added
the
size:XS
🎭 Playwright Test Results❌ Some tests failed ⏰ Completed at: 11/04/2025, 07:02:32 PM UTC 📈 Summary
📊 Test Reports by Browser
🎉 Click on the links above to view detailed test results for each browser configuration. |
christian-byrne
approved these changes
Nov 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #6572 to
rh-testAutomatically created by backport workflow.
┆Issue is synchronized with this Notion page by Unito