Add front end support for type matching #6582
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🎭 Playwright Test Results⏰ Completed at: 11/07/2025, 07:17:22 PM UTC 📈 Summary
📊 Test Reports by Browser
🎉 Click on the links above to view detailed test results for each browser configuration. |
🎨 Storybook Build Status✅ Build completed successfully! ⏰ Completed at: 11/07/2025, 07:04:48 PM UTC 🔗 Links🎉 Your Storybook is ready for review! |
Bundle Size ReportSummary
Category Glance Per-category breakdownApp Entry Points — 3.26 MB (baseline 3.25 MB) • 🔴 +4.59 kBMain entry bundles and manifests
Status: 3 added / 3 removed Graph Workspace — 793 kB (baseline 793 kB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration
Status: 1 added / 1 removed Views & Navigation — 8.18 kB (baseline 8.18 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces
Status: 1 added / 1 removed Panels & Settings — 293 kB (baseline 293 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens
Status: 6 added / 6 removed UI Components — 12.6 kB (baseline 12.6 kB) • ⚪ 0 BReusable component library chunks
Status: 1 added / 1 removed Data & Services — 10.4 kB (baseline 10.4 kB) • ⚪ 0 BStores, services, APIs, and repositories
Status: 2 added / 2 removed Utilities & Hooks — 1.07 kB (baseline 1.07 kB) • ⚪ 0 BHelpers, composables, and utility bundles
Vendor & Third-Party — 5.32 MB (baseline 5.32 MB) • 🔴 +19 BExternal libraries and shared vendor chunks
Status: 3 added / 3 removed Other — 2.55 MB (baseline 2.55 MB) • ⚪ 0 BBundles that do not match a named category
|
I think updating this to be the color of the combiend output type is most correct, but implementing this seems logically excessive and I don't think it will ever be relevant
Collaborator
Author
|
Test failure is unexpected,
EDIT: Figured out both issue with test environment and test, |
dosubot
bot
added
the
size:XL
Now cleans up input link reference and calls onConnectionsChange
clone was causing infinite recursion, missing inputs resulted in broken links
Connecting a new link over an existing link triggers a disconnect event before performing a new connection event. This creates intermediate states which could potentially be invalid. However, disconnecting inputs can only "loosen" the connection logic for other inputs and outputs. This means that the temporary disconnection when swapping links can never create an invalid state. As a result, this debounce is neither required nor useful.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements front end logic to handle MatchType inputs and outputs.
See comfyanonymous/ComfyUI#10644
This allows for the implementation of nodes such as a "switch node" where input types change based on the connections made.
As part of this implementation, significant cleanup is being performed in the reroute code. Extra testing will be required to make sure these changes don't introduce regressions.
┆Issue is synchronized with this Notion page by Unito