Skip to content

Vp v1/align request statements #574

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 73 commits into from
Oct 31, 2025
Merged

Vp v1/align request statements #574

merged 73 commits into from
Oct 31, 2025

Conversation

@soerenbf
Copy link
Collaborator

@soerenbf soerenbf commented Oct 29, 2025

Purpose

A replacement for the changes introduced in #564 and #572

Changes

  • Roll back the breaking changes introduced in WIP: Release/sdk/12 #564 as we no longer try to retrofit changes introduced in the new VP protocol into the old.

Checklist

  • My code follows the style of this project.
  • The code compiles without warnings.
  • I have performed a self-review of the changes.
  • I have documented my code, in particular the intent of the
    hard-to-understand areas.
  • (If necessary) I have updated the CHANGELOG.

soerenbf added 30 commits October 15, 2025 08:49
@soerenbf
Initial draft of id cred presentations
5ec19e6
@soerenbf
Migrate identity proof types to web3 ID
dabf98c
@soerenbf
Route verifiable presentation requests to the old implementation (for…
b21d788 
… now)
@soerenbf
Fix compilation errors after restructure
2bb8819
@soerenbf
Verifiable presentation V1 tests
87ba73d
@soerenbf
Add helper functions for creating context and grpc helper functions f…
76900d4 
…or anchoring
@soerenbf
Add JSON conversion for request + proof types
bb8f398
@soerenbf
Fix anchor check
817f0ea
@soerenbf
Fix example
63f0dd6
@soerenbf
Make the breaking changes to CredentialStatementBuilder more visible
1672e46
@soerenbf
Update changelog with changes introduced
a01c724
@soerenbf
Add audit types to VerifiablefpresentationV1
55fbdfd
@soerenbf
Remove the need for supplying policy for identity commitment inputs
88f8775
@soerenbf
Fix request anchor
5b3ea25
@soerenbf
Merge branch 'vp-v1/id-proofs-mock' into vp-v1/audit-reports
e7325f1
@soerenbf
Fix audit anchor
6d164bc
@soerenbf
A little bit of renaming + usability improvements
a5e2893
@soerenbf
PR feedback
e29255f
@soerenbf
Fix misconception of anchor public info
17bd51b
@soerenbf
Fix lint/tests
3e8c54b
@soerenbf
Merge branch 'vp-v1/id-proofs-mock' into vp-v1/audit-reports
1b4e1d9
@soerenbf
Merge pull request #561 from Concordium/vp-v1/id-proofs-mock
fcca28e 
Vp v1/id proofs mock
@soerenbf
Merge pull request #562 from Concordium/vp-v1/audit-reports
bfb82c5 
Add audit types to `VerifiablefpresentationV1`
@soerenbf
alpha bump
bda4033
@soerenbf
Merge pull request #565 from Concordium/sdk-bump/12.0.0-alpha.0
d6d0a17 
alpha bump
@soerenbf
VP V1 integration docs
1e77bb4
@soerenbf
Fix lint
6486dde
@soerenbf
Add section on JSON and audit records
fff93fc
@soerenbf
Add added page to typedoc config
d1ef1e9
@soerenbf
Audit record docstrings
19c8e7e
@soerenbf soerenbf self-assigned this Oct 29, 2025
@soerenbf soerenbf force-pushed the vp-v1/align-request-statements branch from 51089d0 to 86223ae Compare October 29, 2025 11:53
@soerenbf soerenbf marked this pull request as ready for review October 30, 2025 08:55
@soerenbf soerenbf requested review from DOBEN and limemloh October 30, 2025 08:55
@soerenbf soerenbf force-pushed the vp-v1/align-request-statements branch from 08db819 to c155316 Compare October 30, 2025 12:00
DOBEN
DOBEN reviewed Oct 30, 2025
View reviewed changes
Copy link
Member

@DOBEN DOBEN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well written documentation.

@DOBEN DOBEN self-requested a review October 30, 2025 14:21
@soerenbf soerenbf force-pushed the vp-v1/align-request-statements branch from d708fba to 0902f1e Compare October 31, 2025 13:48
@soerenbf soerenbf merged commit 06d657c into release/sdk/11.1 Oct 31, 2025
11 checks passed
@soerenbf soerenbf deleted the vp-v1/align-request-statements branch October 31, 2025 14:20
@soerenbf soerenbf mentioned this pull request Oct 31, 2025
Draft
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DOBEN DOBEN DOBEN approved these changes

@limemloh limemloh Awaiting requested review from limemloh

Assignees

@soerenbf soerenbf

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@soerenbf @DOBEN