This repository was archived by the owner on Jul 14, 2025. It is now read-only.
Andrew ricker #196
Open
Andrew ricker #196
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed check for zero transfer. Fixes Consensys#47.
Add Codeship badge to README
Add tests for events. Fixes Consensys#15.
Ignore environment test contracts
Make non-state-changing methods in Factory constant
This is not the fancy Simon-approved way of checking for throws. However. In a few short weeks the reverts we have in place will return real error messages to Truffle and then we'll be able to make small changes to this script such that checking for reversion in this way won't be at all hacky, but in fact proper. I don't want to go through the complexity of testing exceptions in the more rigorous way when Metro will be out so soon... And really this is only slightly hacky.
The solidity compiler throws by default if no fallback function is specified.
Change return falses and throws to reverts
This enables people to run npm install and truffle from the base directory, which IMO is more common.
Standard structure
Clean up dead code, since infura doesn't support morden anymore
* Moved the funny quote to look a bit less out in the middle of nowhere * Links for convenience * Clarify how to contribute
Readme improvements
* Update README.md * Moved the funny quote to look a bit less out in the middle of nowhere * Links for convenience * Clarify how to contribute * Update README.md * Test async await (Consensys#71) * Rewrite tests with async/await * Rewrite tests with async/await * Move helpers to utils.js, remove todos * add blank lines between sub-tests, refactor the normal ether transfer test * Await test result
The verifyEIP20 function does two checks to assert whether the code at a given address is known EIP20 code. In the first check, it simply compares the length (in bytes) of the code at the provided address to the length of the known EIP20 code. If that check passes, it would then iterate though the code at the provided address byte by byte and compare each byte to the known EIP20 code, returning false if any byte did not match. A run of the linter initially committed at a783747, the `return true` statement which had come after the byte-comparing for loop was moved inside the for loop such that if the first byte compared was matching, this function would return true even if the rest of the bytes did not match. * Move verifyEIP20's `return true` statement to after both check have completed
Bumps [eslint](https://github.com/eslint/eslint) from 4.13.1 to 4.18.2. - [Release notes](https://github.com/eslint/eslint/releases) - [Changelog](https://github.com/eslint/eslint/blob/master/CHANGELOG.md) - [Commits](eslint/eslint@v4.13.1...v4.18.2) Signed-off-by: dependabot[bot] <[email protected]>
SOLOMANATTI44
approved these changes
Mar 14, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.