feat: forced transaction #798
Merged
+25
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: F Bojarski <[email protected]>
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Signed-off-by: F Bojarski <[email protected]>
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Signed-off-by: F Bojarski <[email protected]>
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
OlivierBBB
approved these changes
Oct 20, 2025
There was a problem hiding this comment.
Does this not need a constraint initializing PROVER_ILLEGAL_TRANSACTION_DETECTED_ACC to 0 ?
There was a problem hiding this comment.
nope, it's 0 on no-user row, and on user row it's the previous one + the flag, so it's implicitely forced to start at 0 at the begining on USER row
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
Add constraints to flag illegal precompile usage and enforce binary transaction-end indicators.
hub/osaka/constraints/forced_transactions.lisp:illegal-precompilescomputed fromPEEK_AT_SCENARIOandscenario/PRC_RIPEMD-160+scenario/PRC_BLAKE2f.PROVER_ILLEGAL_TRANSACTION_DETECTED_ACC(:i16 :fwd) andPROVER_ILLEGAL_TRANSACTION_DETECTED(:binary :bwd) with finalization usingsystem-txn-numbers---user-txn-end.system-txn-numbers---{sysi,sysf,user}-txn-endand aggregatesystem-txn-numbers---txn-endwithforce-binto ensure binary signals.Written by Cursor Bugbot for commit 4eb0fef. This will update automatically on new commits. Configure here.