-
Notifications
You must be signed in to change notification settings - Fork 21
feat: integrate asm implementation of bin module #809
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
DavePearce
merged 2 commits into
master
from
808-feat-use-asm-implementation-of-bin-module
Oct 20, 2025
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,59 @@ | ||
| ;; BIN module | ||
| include "../constants/evm.zkasm" | ||
| include "../util/bit_xoan.zkasm" | ||
| include "../util/byte.zkasm" | ||
| include "../util/signextend.zkasm" | ||
|
|
||
| ;; The bin module (BIN) handles the following 6 EVM instructions : | ||
| ;; 1. AND 2. OR 3. XOR | ||
| ;; 4. NOT 5. BYTE 6. SIGNEXTEND | ||
| ;; The first four correspond to the bitwise operations. | ||
| ;; BYTE and SIGNEXTEND need to extract a byte from ARGUMENT_2. | ||
| pub fn bin(INST=0x16 u8, ARGUMENT_1 u256, ARGUMENT_2 u256) -> (RES u256) { | ||
|
|
||
| if INST==EVM_INST_XOR goto xor_call | ||
| if INST==EVM_INST_OR goto or_call | ||
| if INST==EVM_INST_AND goto and_call | ||
| if INST==EVM_INST_NOT goto not_call | ||
| if INST==EVM_INST_BYTE goto byte_call | ||
| if INST==EVM_INST_SIGNEXTEND goto signextend_call | ||
| fail | ||
| var inst u2 | ||
|
|
||
| xor_call: | ||
| inst = 0 | ||
| RES = bit_xoan_u256(inst, ARGUMENT_1, ARGUMENT_2) | ||
| return | ||
| or_call: | ||
| inst = 1 | ||
| RES = bit_xoan_u256(inst, ARGUMENT_1, ARGUMENT_2) | ||
| return | ||
| and_call: | ||
| inst = 2 | ||
| RES = bit_xoan_u256(inst, ARGUMENT_1, ARGUMENT_2) | ||
| return | ||
| not_call: | ||
| inst = 3 | ||
| RES = bit_xoan_u256(inst, ARGUMENT_1, ARGUMENT_2) | ||
| return | ||
| byte_call: | ||
| var n u5 | ||
| var c0 u251 | ||
| c0, n = ARGUMENT_1 | ||
| if c0 != 0 goto exit_0 | ||
| RES = byte256(ARGUMENT_2, n) | ||
| return | ||
| signextend_call: | ||
| var size u5 | ||
| var c1 u251 | ||
| c1, size = ARGUMENT_1 | ||
| if c1 != 0 goto exit_unchanged | ||
| RES = signextend(size, ARGUMENT_2) | ||
| return | ||
| exit_0: | ||
| RES = 0 | ||
| return | ||
| exit_unchanged: | ||
| RES = ARGUMENT_2 | ||
| return | ||
| } |
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.