46 fixecdata calltoc1membershipwcp

[lorenzogentile404]

Note

Migrates EC-data LaTeX macros to xkeyval key–value arguments and updates all usages, adding explicit fields and minor label tweaks.

• LaTeX macro API (EC_DATA):
  • Introduce ECDATA key set (anchorRow, relOffset, xHi, xLo, yHi, yLo, xSquare*, xCube*, xIm*, xRe*, yIm*, yRe*).
  • Refactor \callToCOneMembership* and \callToWellFormedCoordinates to accept a single key–value arg; update displayed labels (e.g., x coord. hi).
  • Extend WCP/EXT variants to show additional terms (ySquare*, xCubePlusThree*, xSquare*, xCube*).
• Call site updates:
  • Replace positional calls with key–value calls in prc/ecdata/specialized/{ecadd,ecmul,ecpairing}.tex and utils (c1_membership.tex, well_formed_coordinates.tex), wiring new fields to shorthands.
• External calls styling:
  • In pkg/xkeyval_macros/ext_calls.sty, simplify argument labels (e.g., First argument hi/lo).
• Misc:
  • Add _all_prc.mtc{2,3,4} entries in prc/_all_prc.maf.

^{Written by Cursor Bugbot for commit 637bd3c. This will update automatically on new commits. Configure here.}

[lorenzogentile404]

See #47 for review over this changes.

[OlivierBBB]

LGTM mostly, but would request a couple of changes

• the \locPXCube stuff looks valid
• convert all macros in pkg/precompiles.sty to xkeyval

[OlivierBBB]

Why not convert this to xkeyval too ? The whole point of xkeyval is to get rid of numbered arguments.

[cursor]

Bug: Macro Calls Variables Before Definition

The callToCOneMembershipWCP macro uses \locPYSquareHi, \locPYSquareLo, \locPXCubePlusThreeHi, and \locPXCubePlusThreeLo as arguments before they are defined. These variables are only defined later, after the callToCOneMembershipEXT call, which results in an undefined reference error.

 

[OlivierBBB]

LGTM