Skip to content

Rc/teleport #215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Rc/teleport #215

wants to merge 9 commits into from

Conversation

RcColes
Copy link
Contributor

@RcColes RcColes commented May 7, 2018

No description provided.

jnterry
jnterry requested changes May 7, 2018
View reviewed changes
Copy link
Contributor

@jnterry jnterry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Teleport works but this shouldnt be in master since it makes testing impossible beyond the x threshold.

Just merge this branch into what ever we are building the level in, then merge everything into master

qqii
qqii approved these changes May 7, 2018
View reviewed changes
Copy link
Member

@qqii qqii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be merged in so that I can change the TELEPORT_LEFT and TELEPORT_RIGHT when making the map.

@qqii
Copy link
Member

qqii commented May 7, 2018 •
edited
Loading

@grant-m-s the goal is for a "smooth" transition using a long tunnel, it should be 35 long and possibly filled with something.

Codrin-Popa
Codrin-Popa previously approved these changes May 7, 2018
View reviewed changes
Copy link
Contributor

@Codrin-Popa Codrin-Popa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good stuff

@Codrin-Popa Codrin-Popa dismissed their stale review May 7, 2018 21:56

agree with jnterry on this one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qqii qqii qqii approved these changes

@Codrin-Popa Codrin-Popa Codrin-Popa left review comments

@jnterry jnterry Awaiting requested review from jnterry

@AnthonyWharton AnthonyWharton Awaiting requested review from AnthonyWharton

@grant-m-s grant-m-s Awaiting requested review from grant-m-s

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@RcColes @qqii @jnterry @Codrin-Popa @AnthonyWharton @grant-m-s