Add getTicket() function. Add $verbose_mode (default: false). #42
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Helps as the class gets added to code-bases, easier to track it
lsthompson
changed the title
lsthompson
changed the title
danhunsaker
requested changes
Jun 19, 2023
Thanks for the review @danhunsaker - how's the updated pull looking now? Appreciate your pointers on all fronts. I'd like to switch back the reverted-to-error-log section? I'm a fan of passing back the specifics if it's doable. |
lsthompson
added a commit
that referenced
this pull request
Dec 22, 2023
This was referenced Dec 22, 2023
danhunsaker
pushed a commit
that referenced
this pull request
Jun 24, 2024
lsthompson
changed the title
|
@danhunsaker @CpuID could you please test? It's been 2 years now, be nice to merge it in. :) |
|
See #12 (review) re next steps. Let's get that PR sorted first, then move to this one. Also someone needs to sort out the conflicts at the same time, I don't have the free cycles atm to do so. Probably best to sort the other PR conflicts first then once master is clean, sort them here also. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Helps as the class gets added to code-bases, easier to track it. You weren't wrong about not working with it!
Investigate @danhunsaker concept of PSR-3 handling mentioned in Issue #19 back in 2015.
https://www.php-fig.org/psr/psr-3/