Skip to content

feat: removed python2 support #266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 22, 2025
Merged

feat: removed python2 support #266

merged 2 commits into from
Oct 22, 2025

Conversation

@fstagni
Copy link
Contributor

@fstagni fstagni commented Sep 22, 2025 •
edited
Loading

closes #263
closes #254

@fstagni fstagni force-pushed the removePy2 branch 9 times, most recently from 3b1db6e to 807db73 Compare September 22, 2025 10:41
@fstagni fstagni marked this pull request as ready for review September 26, 2025 14:09
This was linked to issues Sep 26, 2025
Python2.7 in CI not supported anymore #263
Open
Integrations test not testing python2 #254
Open
aldbr
aldbr reviewed Oct 13, 2025
View reviewed changes
@fstagni fstagni force-pushed the removePy2 branch 2 times, most recently from 27e8781 to c31fe30 Compare October 13, 2025 15:28
@fstagni fstagni mentioned this pull request Oct 13, 2025
Draft
@aldbr
Copy link
Contributor

aldbr commented Oct 14, 2025

Oops, I see some test failures in the integration tests in your branch, are they expected?

@fstagni
Copy link
Contributor Author

fstagni commented Oct 14, 2025

Oops, I see some test failures in the integration tests in your branch, are they expected?

Yes I see those too, thank you for checking. The failures are there because the DIRAC certification setup is somehow broken. I did not yet look into that.

aldbr
aldbr reviewed Oct 22, 2025
View reviewed changes
@fstagni fstagni merged commit 6ba51f7 into DIRACGrid:devel Oct 22, 2025
8 checks passed
@chrisburr
Copy link
Member

Why was this merged before removing the python 2 pilot tests from DIRAC?

Also 264587c is broken. The commit message talks about absolute imports when it's using relative ones and relative ones don't make sense in the way the pilotwrapper works.

@chrisburr chrisburr mentioned this pull request Oct 24, 2025
Merged
@fstagni
Copy link
Contributor Author

fstagni commented Oct 24, 2025

Why was this merged before removing the python 2 pilot tests from DIRAC?

Also 264587c is broken. The commit message talks about absolute imports when it's using relative ones and relative ones don't make sense in the way the pilotwrapper works.

Indeed, it was clearly not tested enough, yesterday I was trying to find an easy way out but failed to do it quickly. So, you did well to revert it for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aldbr aldbr aldbr approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Python2.7 in CI not supported anymore Integrations test not testing python2

3 participants

@fstagni @aldbr @chrisburr