Add job monitoring utilities to the routers #593
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
With DIRACGrid/DIRAC#8260 |
fstagni
reviewed
Jul 15, 2025
| search, | ||
| sorts, | ||
| *, | ||
| per_page: int = 10000, |
There was a problem hiding this comment.
Seems like a very large number, why?
There was a problem hiding this comment.
I will decrease it*, it was a debug value
| metadata = DummyDBBase.metadata | ||
|
|
||
| async def summary(self, group_by, search) -> list[dict[str, str | int]]: | ||
| async def dummy_summary(self, group_by, search) -> list[dict[str, str | int]]: |
There was a problem hiding this comment.
I rewrote the search function for BaseDB. The new search function has to be generic, and takes all regular parameters plus a Model which is for example PilotAgents or PilotSecrets.
Calling directly db.summary will require this Model parameter, whereas dummy_summary will add this Model parameter.
Maybe I can rename the generic search function : _search (to make it private)
|
Need more tests |
Robin-Van-de-Merghel
force-pushed
the
robin-update-job-monitoring
branch
from
c427dd5 to
83ec8af
Compare
Robin-Van-de-Merghel
force-pushed
the
robin-update-job-monitoring
branch
from
83ec8af to
e7fbedb
Compare
|
See comments above, we need to review it... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To update the job monitoring, we need a
getInputDataand aget_job_parametersrouter.