Skip to content

Conversation

@spenke91
Copy link

We realized the examples were not properly working. This PR adds some minor fixes to ensure they are working as expected, i.e., as the original t8code tutorials.

@JoshuaLampert
Copy link
Collaborator

Thanks! Could you please run the formatter?

julia -e 'using Pkg; Pkg.add(PackageSpec(name = "JuliaFormatter", version="1.0.60"))'
julia -e 'using JuliaFormatter; format(".")'

We should run the examples in CI to ensure they are working, cf. #29. Would you be willing to add such a GitHub action?

@spenke91
Copy link
Author

spenke91 commented Jun 2, 2025

Thanks! Could you please run the formatter?

julia -e 'using Pkg; Pkg.add(PackageSpec(name = "JuliaFormatter", version="1.0.60"))'
julia -e 'using JuliaFormatter; format(".")'

We should run the examples in CI to ensure they are working, cf. #29. Would you be willing to add such a GitHub action?

Hi @JoshuaLampert , thanks for your comment (which I somehow didn't notice until now). Sure, I will add it to the CI.

Speaking of the CI: Do you have any idea why the CI is not working anymore? There seems to be some kind of SegFault. I started playing around in #86 a little, but can not yet really identify it...

@JoshuaLampert
Copy link
Collaborator

Yes, I noticed that, too. However, I don't know where it comes from. Interestingly, in this PR, CI is passing.

@JoshuaLampert
Copy link
Collaborator

Ok, after rerunning, it is also failing here. Looks like it's non-deterministic 😕

@spenke91
Copy link
Author

spenke91 commented Jun 2, 2025

Yes, I noticed that, too. However, I don't know where it comes from. Interestingly, in this PR, CI is passing.

If I saw this correctly in the dummy PR, it sometimes worked and sometimes failed, which hints towards some memory bug 🤔

@JoshuaLampert
Copy link
Collaborator

Yes, probably. Have you been able to find out, which specific test causes the problem?

@spenke91
Copy link
Author

spenke91 commented Jun 3, 2025

Yes, probably. Have you been able to find out, which specific test causes the problem?

Well, I thought I had narrowed it down to the test cmesh/test_readmshfile.jl and this part:

image

However, this was before I realized the bug was non-deterministic, so one would have to double-check 🙄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants