Skip to content

Conversation

sandro-elsweijer
Copy link
Member

@sandro-elsweijer sandro-elsweijer commented Jul 18, 2025

Closes #1773

Describe your changes here:
The vertex connectivity currently will be built as soon as a global vertex is added.
This adds the possibility to leave the vertex connectivity completely out if not needed.
The vertex conn will now be built if the user sets the cmesh to do so or if a global vertex is added.
In the future the msh or vtk reader can collect this information from the uncommitted cmesh and then read in the global vertices or not.

Note: most of this are removed trailing white spaces because my vscode deletes them during saving a file.

preparation for #1771

All these boxes must be checked by the AUTHOR before requesting review:

  • The PR is small enough to be reviewed easily. If not, consider splitting up the changes in multiple PRs.
  • The title starts with one of the following prefixes: Documentation:, Bugfix:, Feature:, Improvement: or Other:.
  • If the PR is related to an issue, make sure to link it.
  • The author made sure that, as a reviewer, he/she would check all boxes below.

All these boxes must be checked by the REVIEWERS before merging the pull request:

As a reviewer please read through all the code lines and make sure that the code is fully understood, bug free, well-documented and well-structured.

General

  • The reviewer executed the new code features at least once and checked the results manually.
  • The code follows the t8code coding guidelines.
  • New source/header files are properly added to the CMake files.
  • The code is well documented. In particular, all function declarations, structs/classes and their members have a proper doxygen documentation.
  • All new algorithms and data structures are sufficiently optimal in terms of memory and runtime (If this should be merged, but there is still potential for optimization, create a new issue).

Tests

  • The code is covered in an existing or new test case using Google Test.
  • The code coverage of the project (reported in the CI) should not decrease. If coverage is decreased, make sure that this is reasonable and acceptable.
  • Valgrind doesn't find any bugs in the new code. This script can be used to check for errors; see also this wiki article.

If the Pull request introduces code that is not covered by the github action (for example coupling with a new library):

  • Should this use case be added to the github action?
  • If not, does the specific use case compile and all tests pass (check manually).

Scripts and Wiki

  • If a new directory with source files is added, it must be covered by the script/find_all_source_files.scp to check the indentation of these files.
  • If this PR introduces a new feature, it must be covered in an example or tutorial and a Wiki article.

License

  • The author added a BSD statement to doc/ (or already has one).

@sandro-elsweijer sandro-elsweijer added priority:medium Should be solved within half a year workload:low Would take half a day or less labels Jul 18, 2025
@sandro-elsweijer sandro-elsweijer force-pushed the fix-vertex_connectivity branch from 5001a3f to c40cafa Compare July 28, 2025 13:05
@sandro-elsweijer sandro-elsweijer force-pushed the fix-vertex_connectivity branch from c40cafa to c2fdb8a Compare July 31, 2025 11:58
Base automatically changed from fix-vertex_connectivity to main July 31, 2025 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority:medium Should be solved within half a year workload:low Would take half a day or less
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant