-
Notifications
You must be signed in to change notification settings - Fork 61
Feature: Compute the eclass of a tree or ghost neighbor in the cmesh #1806
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…lass of a cmesh neighbor tree Given a local tree or ghost tree and a face this function returns the eclass of the neighbor tree. If no neighbor is found it returns T8_ECLASS_INVALID
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1806 +/- ##
==========================================
- Coverage 74.51% 74.43% -0.09%
==========================================
Files 100 101 +1
Lines 19104 19203 +99
==========================================
+ Hits 14236 14293 +57
- Misses 4868 4910 +42 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only a small change required in my opinion! Thanks for the addition.
} | ||
|
||
t8_eclass_t | ||
t8_cmesh_get_tree_face_neighbor_eclass (const t8_cmesh_t cmesh, const t8_locidx_t ltreeid, const int face) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please assert that face is a positive number, or make it an uint.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
Note that t8_cmesh_get_face_neighbor will also performs this check and also check whether face is smaller than the number of faces.
The latter is difficult to check at this place, since we do not have access to the eclass of the tree immediately.
And i figure it is ok to just check against 0 here since t8_cmesh_get_face_neighbor will do the other check.
Closes #1805
Describe your changes here:
Implements
t8_cmesh_get_tree_face_neighbor_eclass
Given a local tree or ghost tree and a face this function returns the eclass of the neighbor tree.
If no neighbor is found it returns T8_ECLASS_INVALID
Added the function to test cases that already compute the face neighbor in order to double check the eclass and the new function.
All these boxes must be checked by the AUTHOR before requesting review:
Documentation:
,Bugfix:
,Feature:
,Improvement:
orOther:
.All these boxes must be checked by the REVIEWERS before merging the pull request:
As a reviewer please read through all the code lines and make sure that the code is fully understood, bug free, well-documented and well-structured.
General
Tests
If the Pull request introduces code that is not covered by the github action (for example coupling with a new library):
Scripts and Wiki
script/find_all_source_files.scp
to check the indentation of these files.License
doc/
(or already has one).