Skip to content

Conversation

dleung25
Copy link

@dleung25 dleung25 commented Dec 10, 2018

this PR builds upon #8 , which isn't merged yet, so this PR includes those file changes as well.

  • Changed name displayed on the icon on the phone/emulator from ChatActivity to DarkChatter
  • Added pop-up messages for Register, Connect, and Send Messages when they fail - right now user has no idea what works and what doesn't as there is no response to the user that something has succeeded

(most of the changes compared to from #8 are in ChatActivity.java and ChatConnection.java, since it's not clear from the files changed standpoint)

@dleung25
Copy link
Author

looks like the check failed, if someone can review this PR it'd be greatly appreciated

@AHKol
Copy link
Member

AHKol commented Dec 10, 2018

I don't think Travis was properly integrated, I'll disable it until a working version can be set up.

@AHKol
Copy link
Member

AHKol commented Dec 10, 2018

Can you try deleting your .travis.yml file and committing again. It seems to be using the old config file.

@dleung25
Copy link
Author

Done, thanks for the quick heads up

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants