Skip to content

Conversation

@sulewskiprzemyslaw
Copy link
Contributor

No description provided.

Copy link
Contributor

@krystian-hebel krystian-hebel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Those describe TPM2.0 only, and don't mention which PCR bank is considered.

Comment on lines +45 to +46
1. Disconnect the power source, and remove the battery if present.
1. Connect power and battery again.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this is required, there are bigger problems with the platform...

Comment on lines 92 to 93
- PCR0 - PCR7 values should not be equal zero; they contains firmware
measurements,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assumes UEFI, with legacy payload most of those PCRs are unused. I think only PCR2 is used in each case.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed in af16620


- PCR0 - PCR7 values should not be equal zero; they contains firmware
measurements,
- PCR8, PCR9 and PCR14 values should not be equal zero; they contains GRUB
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, PCR14 is used by MOK. Should be added to description.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed in b75f03f

measurements,
- PCR8, PCR9 and PCR14 values should not be equal zero; they contains GRUB
measurements,
- PCR10 value should not be equal zero.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only if IMA is enabled.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed in 0ba4fb8

- PCR10 value should not be equal zero.

1. Between subsequent boots above mentioned PCRs values should remain unchanged,
except PCR10.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why can PCR10 change here but not for earlier tests? 🤔

1. Power on the DUT.
1. Boot into the system.
1. Log into the system by using the proper login and password.
1. Open a terminal window and run the following command:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What to do with results?

measurements,
- PCR10 value should not be equal zero.

1. Between subsequent boots above mentioned PCRs values should remain unchanged.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is meant by "subsequent boots"? Is there expected to be a reboot between tests, or just S3 sleep? I also think that PCR10 may change here.

@Mixss Mixss force-pushed the tpm_stability_tests branch from e131650 to 5a8a329 Compare September 1, 2023 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants