Reapply "make `DD_DOTNET_TRACER_HOME` optional in managed loader" #7767

lucaspimentel · 2025-11-03T23:10:34Z

Summary of changes

Original PR #7568 (d0fe312) was reverted in #7704 (b59dea4) because it broke Continuous Profiling integration tests on master. The issue was fixed in #7705, so I'm trying to reapply the original PR:

Make DD_DOTNET_TRACER_HOME optional. If not set, try to figure out the path from COR_PROFILER_PATH/CORECLR_PROFILER_PATH and friends.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

tracer/src/Datadog.Trace.ClrProfiler.Managed.Loader/Startup.cs

dd-trace-dotnet-ci-bot · 2025-11-03T23:52:47Z

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing This PR (7767) and master.

✅ No regressions detected - check the details below

Full Metrics Comparison

FakeDbCommand

Metric	Master (Mean ± 95% CI)	Current (Mean ± 95% CI)	Change	Status
.NET Framework 4.8 - Baseline
duration	75.39 ± (75.04 - 75.82) ms	75.36 ± (75.29 - 76.01) ms	-0.0%	✅
.NET Framework 4.8 - Bailout
duration	79.26 ± (79.00 - 79.47) ms	78.86 ± (78.64 - 79.29) ms	-0.5%	✅
.NET Framework 4.8 - CallTarget+Inlining+NGEN
duration	1108.38 ± (1111.88 - 1122.66) ms	1090.82 ± (1092.07 - 1100.57) ms	-1.6%	✅
.NET Core 3.1 - Baseline
process.internal_duration_ms	22.91 ± (22.83 - 22.98) ms	22.77 ± (22.69 - 22.84) ms	-0.6%	✅
process.time_to_main_ms	87.06 ± (86.78 - 87.34) ms	86.62 ± (86.26 - 86.98) ms	-0.5%	✅
runtime.dotnet.exceptions.count	0 ± (0 - 0)	0 ± (0 - 0)	+0.0%	✅
runtime.dotnet.mem.committed	10.88 ± (10.88 - 10.88) MB	10.89 ± (10.89 - 10.89) MB	+0.1%	✅⬆️
runtime.dotnet.threads.count	12 ± (12 - 12)	12 ± (12 - 12)	+0.0%	✅
.NET Core 3.1 - Bailout
process.internal_duration_ms	22.87 ± (22.81 - 22.93) ms	22.86 ± (22.78 - 22.94) ms	-0.0%	✅
process.time_to_main_ms	88.78 ± (88.49 - 89.07) ms	89.42 ± (89.04 - 89.80) ms	+0.7%	✅⬆️
runtime.dotnet.exceptions.count	0 ± (0 - 0)	0 ± (0 - 0)	+0.0%	✅
runtime.dotnet.mem.committed	10.92 ± (10.92 - 10.92) MB	10.93 ± (10.93 - 10.94) MB	+0.1%	✅⬆️
runtime.dotnet.threads.count	13 ± (13 - 13)	13 ± (13 - 13)	+0.0%	✅
.NET Core 3.1 - CallTarget+Inlining+NGEN
process.internal_duration_ms	219.93 ± (218.58 - 221.29) ms	221.50 ± (220.17 - 222.83) ms	+0.7%	✅⬆️
process.time_to_main_ms	548.73 ± (547.60 - 549.86) ms	551.62 ± (550.49 - 552.75) ms	+0.5%	✅⬆️
runtime.dotnet.exceptions.count	0 ± (0 - 0)	0 ± (0 - 0)	+0.0%	✅
runtime.dotnet.mem.committed	52.60 ± (52.57 - 52.62) MB	52.41 ± (52.39 - 52.44) MB	-0.3%	✅
runtime.dotnet.threads.count	28 ± (28 - 28)	28 ± (28 - 28)	+0.1%	✅⬆️
.NET 6 - Baseline
process.internal_duration_ms	21.60 ± (21.53 - 21.67) ms	21.58 ± (21.53 - 21.63) ms	-0.1%	✅
process.time_to_main_ms	75.20 ± (74.85 - 75.55) ms	75.47 ± (75.20 - 75.75) ms	+0.4%	✅⬆️
runtime.dotnet.exceptions.count	0 ± (0 - 0)	0 ± (0 - 0)	+0.0%	✅
runtime.dotnet.mem.committed	10.59 ± (10.58 - 10.59) MB	10.61 ± (10.61 - 10.61) MB	+0.2%	✅⬆️
runtime.dotnet.threads.count	10 ± (10 - 10)	10 ± (10 - 10)	+0.0%	✅
.NET 6 - Bailout
process.internal_duration_ms	21.56 ± (21.48 - 21.64) ms	21.57 ± (21.51 - 21.62) ms	+0.0%	✅⬆️
process.time_to_main_ms	77.09 ± (76.76 - 77.43) ms	77.03 ± (76.76 - 77.30) ms	-0.1%	✅
runtime.dotnet.exceptions.count	0 ± (0 - 0)	0 ± (0 - 0)	+0.0%	✅
runtime.dotnet.mem.committed	10.64 ± (10.63 - 10.64) MB	10.64 ± (10.64 - 10.65) MB	+0.1%	✅⬆️
runtime.dotnet.threads.count	11 ± (11 - 11)	11 ± (11 - 11)	+0.0%	✅
.NET 6 - CallTarget+Inlining+NGEN
process.internal_duration_ms	205.68 ± (204.42 - 206.94) ms	206.44 ± (205.20 - 207.68) ms	+0.4%	✅⬆️
process.time_to_main_ms	510.72 ± (509.74 - 511.69) ms	507.03 ± (506.13 - 507.93) ms	-0.7%	✅
runtime.dotnet.exceptions.count	0 ± (0 - 0)	0 ± (0 - 0)	+0.0%	✅
runtime.dotnet.mem.committed	51.78 ± (51.74 - 51.82) MB	51.57 ± (51.53 - 51.61) MB	-0.4%	✅
runtime.dotnet.threads.count	28 ± (28 - 28)	28 ± (28 - 28)	-0.0%	✅
.NET 8 - Baseline
process.internal_duration_ms	19.76 ± (19.69 - 19.82) ms	19.89 ± (19.83 - 19.95) ms	+0.7%	✅⬆️
process.time_to_main_ms	75.24 ± (74.90 - 75.58) ms	75.58 ± (75.27 - 75.88) ms	+0.4%	✅⬆️
runtime.dotnet.exceptions.count	0 ± (0 - 0)	0 ± (0 - 0)	+0.0%	✅
runtime.dotnet.mem.committed	7.61 ± (7.61 - 7.62) MB	7.64 ± (7.64 - 7.65) MB	+0.4%	✅⬆️
runtime.dotnet.threads.count	10 ± (10 - 10)	10 ± (10 - 10)	+0.0%	✅
.NET 8 - Bailout
process.internal_duration_ms	19.58 ± (19.53 - 19.63) ms	19.86 ± (19.80 - 19.91) ms	+1.4%	✅⬆️
process.time_to_main_ms	75.46 ± (75.13 - 75.80) ms	76.34 ± (76.03 - 76.64) ms	+1.2%	✅⬆️
runtime.dotnet.exceptions.count	0 ± (0 - 0)	0 ± (0 - 0)	+0.0%	✅
runtime.dotnet.mem.committed	7.67 ± (7.66 - 7.67) MB	7.69 ± (7.68 - 7.69) MB	+0.2%	✅⬆️
runtime.dotnet.threads.count	11 ± (11 - 11)	11 ± (11 - 11)	+0.0%	✅
.NET 8 - CallTarget+Inlining+NGEN
process.internal_duration_ms	188.91 ± (187.99 - 189.83) ms	191.22 ± (190.33 - 192.11) ms	+1.2%	✅⬆️
process.time_to_main_ms	488.40 ± (487.39 - 489.41) ms	483.19 ± (482.13 - 484.25) ms	-1.1%	✅
runtime.dotnet.exceptions.count	0 ± (0 - 0)	0 ± (0 - 0)	+0.0%	✅
runtime.dotnet.mem.committed	38.86 ± (38.83 - 38.90) MB	38.77 ± (38.73 - 38.81) MB	-0.2%	✅
runtime.dotnet.threads.count	27 ± (27 - 27)	27 ± (27 - 27)	+0.1%	✅⬆️

HttpMessageHandler

Metric	Master (Mean ± 95% CI)	Current (Mean ± 95% CI)	Change	Status
.NET Framework 4.8 - Baseline
duration	191.55 ± (191.38 - 192.05) ms	192.96 ± (192.84 - 193.69) ms	+0.7%	✅⬆️
.NET Framework 4.8 - Bailout
duration	194.96 ± (194.79 - 195.34) ms	196.38 ± (196.20 - 196.97) ms	+0.7%	✅⬆️
.NET Framework 4.8 - CallTarget+Inlining+NGEN
duration	1206.94 ± (1197.95 - 1208.71) ms	1156.94 ± (1165.83 - 1176.08) ms	-4.1%	✅
.NET Core 3.1 - Baseline
process.internal_duration_ms	200.58 ± (200.09 - 201.06) ms	188.43 ± (188.02 - 188.85) ms	-6.1%	✅
process.time_to_main_ms	87.03 ± (86.78 - 87.29) ms	80.79 ± (80.56 - 81.01) ms	-7.2%	✅
runtime.dotnet.exceptions.count	3 ± (3 - 3)	3 ± (3 - 3)	+0.0%	✅
runtime.dotnet.mem.committed	15.97 ± (15.95 - 15.99) MB	16.10 ± (16.07 - 16.12) MB	+0.8%	✅⬆️
runtime.dotnet.threads.count	20 ± (20 - 20)	20 ± (19 - 20)	-1.2%	✅
.NET Core 3.1 - Bailout
process.internal_duration_ms	202.57 ± (202.12 - 203.01) ms	187.16 ± (186.84 - 187.49) ms	-7.6%	✅
process.time_to_main_ms	89.15 ± (88.91 - 89.39) ms	81.98 ± (81.84 - 82.12) ms	-8.0%	✅
runtime.dotnet.exceptions.count	3 ± (3 - 3)	3 ± (3 - 3)	+0.0%	✅
runtime.dotnet.mem.committed	15.99 ± (15.97 - 16.01) MB	16.18 ± (16.15 - 16.21) MB	+1.2%	✅⬆️
runtime.dotnet.threads.count	21 ± (20 - 21)	21 ± (21 - 21)	+0.3%	✅⬆️
.NET Core 3.1 - CallTarget+Inlining+NGEN
process.internal_duration_ms	400.87 ± (398.26 - 403.48) ms	396.50 ± (394.06 - 398.95) ms	-1.1%	✅
process.time_to_main_ms	532.09 ± (530.75 - 533.42) ms	517.31 ± (516.69 - 517.93) ms	-2.8%	✅
runtime.dotnet.exceptions.count	3 ± (3 - 3)	3 ± (3 - 3)	+0.0%	✅
runtime.dotnet.mem.committed	63.40 ± (63.27 - 63.53) MB	63.01 ± (62.86 - 63.16) MB	-0.6%	✅
runtime.dotnet.threads.count	29 ± (29 - 29)	29 ± (29 - 29)	-0.1%	✅
.NET 6 - Baseline
process.internal_duration_ms	194.11 ± (193.65 - 194.58) ms	192.13 ± (191.81 - 192.45) ms	-1.0%	✅
process.time_to_main_ms	70.60 ± (70.41 - 70.79) ms	69.77 ± (69.58 - 69.95) ms	-1.2%	✅
runtime.dotnet.exceptions.count	4 ± (4 - 4)	4 ± (4 - 4)	+0.0%	✅
runtime.dotnet.mem.committed	16.35 ± (16.32 - 16.38) MB	16.40 ± (16.37 - 16.43) MB	+0.3%	✅⬆️
runtime.dotnet.threads.count	19 ± (19 - 19)	19 ± (19 - 19)	+1.0%	✅⬆️
.NET 6 - Bailout
process.internal_duration_ms	194.30 ± (193.83 - 194.77) ms	190.84 ± (190.58 - 191.11) ms	-1.8%	✅
process.time_to_main_ms	72.12 ± (71.95 - 72.29) ms	70.51 ± (70.41 - 70.61) ms	-2.2%	✅
runtime.dotnet.exceptions.count	4 ± (4 - 4)	4 ± (4 - 4)	+0.0%	✅
runtime.dotnet.mem.committed	16.39 ± (16.32 - 16.45) MB	16.12 ± (15.97 - 16.27) MB	-1.6%	✅
runtime.dotnet.threads.count	20 ± (20 - 20)	19 ± (19 - 20)	-2.6%	✅
.NET 6 - CallTarget+Inlining+NGEN
process.internal_duration_ms	420.35 ± (417.48 - 423.21) ms	408.36 ± (405.81 - 410.91) ms	-2.9%	✅
process.time_to_main_ms	498.03 ± (496.84 - 499.21) ms	480.66 ± (480.08 - 481.25) ms	-3.5%	✅
runtime.dotnet.exceptions.count	4 ± (4 - 4)	4 ± (4 - 4)	+0.0%	✅
runtime.dotnet.mem.committed	62.46 ± (62.33 - 62.59) MB	62.24 ± (62.10 - 62.38) MB	-0.3%	✅
runtime.dotnet.threads.count	29 ± (29 - 30)	30 ± (29 - 30)	+0.1%	✅⬆️
.NET 8 - Baseline
process.internal_duration_ms	192.85 ± (192.40 - 193.29) ms	190.36 ± (189.99 - 190.73) ms	-1.3%	✅
process.time_to_main_ms	70.22 ± (70.04 - 70.41) ms	69.32 ± (69.14 - 69.50) ms	-1.3%	✅
runtime.dotnet.exceptions.count	4 ± (4 - 4)	4 ± (4 - 4)	+0.0%	✅
runtime.dotnet.mem.committed	11.67 ± (11.65 - 11.69) MB	11.73 ± (11.70 - 11.76) MB	+0.5%	✅⬆️
runtime.dotnet.threads.count	18 ± (18 - 18)	18 ± (18 - 18)	-0.2%	✅
.NET 8 - Bailout
process.internal_duration_ms	191.73 ± (191.36 - 192.11) ms	190.34 ± (189.96 - 190.72) ms	-0.7%	✅
process.time_to_main_ms	71.47 ± (71.30 - 71.64) ms	70.78 ± (70.64 - 70.92) ms	-1.0%	✅
runtime.dotnet.exceptions.count	4 ± (4 - 4)	4 ± (4 - 4)	+0.0%	✅
runtime.dotnet.mem.committed	11.74 ± (11.72 - 11.76) MB	11.79 ± (11.76 - 11.82) MB	+0.4%	✅⬆️
runtime.dotnet.threads.count	19 ± (19 - 19)	19 ± (19 - 19)	-0.2%	✅
.NET 8 - CallTarget+Inlining+NGEN
process.internal_duration_ms	361.21 ± (359.95 - 362.48) ms	359.76 ± (358.35 - 361.18) ms	-0.4%	✅
process.time_to_main_ms	468.46 ± (467.76 - 469.15) ms	458.15 ± (457.47 - 458.82) ms	-2.2%	✅
runtime.dotnet.exceptions.count	4 ± (4 - 4)	4 ± (4 - 4)	+0.0%	✅
runtime.dotnet.mem.committed	50.51 ± (50.48 - 50.54) MB	50.30 ± (50.27 - 50.33) MB	-0.4%	✅
runtime.dotnet.threads.count	29 ± (29 - 29)	29 ± (29 - 29)	+0.1%	✅⬆️

Comparison explanation

Execution-time benchmarks measure the whole time it takes to execute a program, and are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are highlighted in **red**. The following thresholds were used for comparing the execution times:

Welch test with statistical test for significance of 5%
Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

Duration charts

FakeDbCommand (.NET Framework 4.8)

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.8)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (7767) - mean (76ms)  : 70, 81
    master - mean (75ms)  : 70, 81

    section Bailout
    This PR (7767) - mean (79ms)  : 74, 84
    master - mean (79ms)  : 76, 83

    section CallTarget+Inlining+NGEN
    This PR (7767) - mean (1,096ms)  : 1035, 1158
    master - mean (1,117ms)  : 1037, 1197

FakeDbCommand (.NET Core 3.1)

gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (7767) - mean (117ms)  : 110, 124
    master - mean (117ms)  : 112, 122

    section Bailout
    This PR (7767) - mean (120ms)  : 113, 127
    master - mean (119ms)  : 114, 124

    section CallTarget+Inlining+NGEN
    This PR (7767) - mean (814ms)  : 782, 846
    master - mean (806ms)  : 764, 847

FakeDbCommand (.NET 6)

gantt
    title Execution time (ms) FakeDbCommand (.NET 6)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (7767) - mean (104ms)  : 99, 109
    master - mean (104ms)  : 96, 111

    section Bailout
    This PR (7767) - mean (106ms)  : 100, 111
    master - mean (106ms)  : 99, 112

    section CallTarget+Inlining+NGEN
    This PR (7767) - mean (745ms)  : 715, 776
    master - mean (745ms)  : 714, 777

FakeDbCommand (.NET 8)

gantt
    title Execution time (ms) FakeDbCommand (.NET 8)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (7767) - mean (104ms)  : 98, 110
    master - mean (103ms)  : 96, 111

    section Bailout
    This PR (7767) - mean (104ms)  : 99, 110
    master - mean (103ms)  : 96, 110

    section CallTarget+Inlining+NGEN
    This PR (7767) - mean (711ms)  : 682, 740
    master - mean (707ms)  : 669, 746

HttpMessageHandler (.NET Framework 4.8)

gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.8)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (7767) - mean (193ms)  : 189, 198
    master - mean (192ms)  : 189, 195

    section Bailout
    This PR (7767) - mean (197ms)  : 193, 200
    master - mean (195ms)  : 192, 198

    section CallTarget+Inlining+NGEN
    This PR (7767) - mean (1,171ms)  : 1092, 1250
    master - mean (1,203ms)  : 1127, 1280

HttpMessageHandler (.NET Core 3.1)

gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (7767) - mean (278ms)  : 272, 284
    master - mean (297ms)  : 288, 306

    section Bailout
    This PR (7767) - mean (278ms)  : 274, 282
    master - mean (301ms)  : 294, 308

    section CallTarget+Inlining+NGEN
    This PR (7767) - mean (952ms)  : 912, 991
    master - mean (977ms)  : 931, 1023

HttpMessageHandler (.NET 6)

gantt
    title Execution time (ms) HttpMessageHandler (.NET 6)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (7767) - mean (270ms)  : 265, 275
    master - mean (273ms)  : 267, 279

    section Bailout
    This PR (7767) - mean (269ms)  : 266, 273
    master - mean (275ms)  : 267, 283

    section CallTarget+Inlining+NGEN
    This PR (7767) - mean (922ms)  : 877, 967
    master - mean (958ms)  : 897, 1019

HttpMessageHandler (.NET 8)

gantt
    title Execution time (ms) HttpMessageHandler (.NET 8)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (7767) - mean (269ms)  : 263, 275
    master - mean (273ms)  : 264, 281

    section Bailout
    This PR (7767) - mean (271ms)  : 266, 275
    master - mean (273ms)  : 266, 279

    section CallTarget+Inlining+NGEN
    This PR (7767) - mean (850ms)  : 825, 875
    master - mean (862ms)  : 834, 890

andrewlock

LGTM (assuming direct revert, I didn't re-review) as long as you've done an "all products" run in CI 🙂

datadog-datadog-prod-us1 · 2025-11-05T18:16:56Z

⚠️ Tests

⚠️ Warnings

🧪 2 Tests failed

❄️ Known flaky: ShouldGetContentionSamples from Datadog.Profiler.IntegrationTests.Contention.ContentionProfilerTest (Datadog)
Expected threadIds {16305, 16306, 16307, 16308, 16309, 16310, 16315, 16316, 16317, 16298, 16299, 16300, 16301, 16302, 16303, 16304, 16311, 16312, 16313, 16314, 16284, 16290, 16297, 16324} to contain 16261 because Unknown blocking thread id 16261.
ShouldGetContentionSamples from Datadog.Profiler.IntegrationTests.Contention.ContentionProfilerTest (Datadog)
Expected threadIds {4680, 1540, 2448, 7664, 1132, 7768, 1784, 7800, 3084, 5428, 7868, 5876, 7476, 7424, 3200, 1220, 7832, 7344, 2052, 6928, 7020, 2160, 988, 7408, 4768} to contain 2224 because Unknown blocking thread id 2224.

ℹ️ Info

❄️ No new flaky tests detected

_{This comment will be updated automatically if new data arrives.

🔗 Commit SHA: fd6e208 | Docs | Datadog PR Page | Was this helpful? Give us feedback!}

pr-commenter · 2025-11-07T23:22:19Z

Benchmarks

Benchmarks Report for benchmark platform 🐌

Benchmarks for #7767 compared to master:

1 benchmarks are faster, with geometric mean 1.158
1 benchmarks are slower, with geometric mean 1.130
5 benchmarks have fewer allocations
1 benchmarks have more allocations

The following thresholds were used for comparing the benchmark speeds:

Mann–Whitney U test with statistical test for significance of 5%
Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Same speed ✔️ More allocations ⚠️

More allocations ⚠️ in #7767

Benchmark	Base Allocated	Diff Allocated	Change	Change %
Benchmarks.Trace.ActivityBenchmark.StartStopWithChild‑netcoreapp3.1	5.67 KB	5.72 KB	58 B	1.02%

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	`StartStopWithChild`	net6.0	11.1μs	61.4ns	389ns	0	0	0	5.52 KB
master	`StartStopWithChild`	netcoreapp3.1	13.6μs	70.6ns	339ns	0	0	0	5.67 KB
master	`StartStopWithChild`	net472	22.6μs	128ns	914ns	1.06	0.319	0.106	6.07 KB
#7767	`StartStopWithChild`	net6.0	10.6μs	55.6ns	289ns	0	0	0	5.5 KB
#7767	`StartStopWithChild`	netcoreapp3.1	13.5μs	71.7ns	365ns	0	0	0	5.72 KB
#7767	`StartStopWithChild`	net472	21.9μs	114ns	604ns	0.904	0.339	0	6.09 KB

Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Fewer allocations 🎉

Fewer allocations 🎉 in #7767

Benchmark	Base Allocated	Diff Allocated	Change	Change %
Benchmarks.Trace.AgentWriterBenchmark.WriteAndFlushEnrichedTraces‑net472	3.35 KB	3.31 KB	-46 B	-1.37%

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Allocated
master	`WriteAndFlushEnrichedTraces`	net6.0	941μs	277ns	961ns	2.71 KB
master	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	1.03ms	94.7ns	367ns	2.7 KB
master	`WriteAndFlushEnrichedTraces`	net472	1.21ms	603ns	2.26μs	3.35 KB
#7767	`WriteAndFlushEnrichedTraces`	net6.0	930μs	72.1ns	250ns	2.71 KB
#7767	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	1.01ms	114ns	411ns	2.7 KB
#7767	`WriteAndFlushEnrichedTraces`	net472	1.21ms	69.2ns	268ns	3.31 KB

Benchmarks.Trace.Asm.AppSecBodyBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`AllCycleSimpleBody`	net6.0	1.09μs	5.65ns	27.1ns	0	1.22 KB
master	`AllCycleSimpleBody`	netcoreapp3.1	1.45μs	7.9ns	46ns	0	1.2 KB
master	`AllCycleSimpleBody`	net472	1.03μs	0.667ns	2.41ns	0.192	1.23 KB
master	`AllCycleMoreComplexBody`	net6.0	7.01μs	34.1ns	145ns	0	4.72 KB
master	`AllCycleMoreComplexBody`	netcoreapp3.1	9.05μs	46ns	200ns	0	4.62 KB
master	`AllCycleMoreComplexBody`	net472	7.69μs	4.72ns	16.4ns	0.731	4.74 KB
master	`ObjectExtractorSimpleBody`	net6.0	324ns	1.8ns	11.1ns	0	280 B
master	`ObjectExtractorSimpleBody`	netcoreapp3.1	391ns	2.21ns	14.3ns	0	272 B
master	`ObjectExtractorSimpleBody`	net472	301ns	0.108ns	0.405ns	0.044	281 B
master	`ObjectExtractorMoreComplexBody`	net6.0	6.27μs	32.1ns	151ns	0	3.78 KB
master	`ObjectExtractorMoreComplexBody`	netcoreapp3.1	7.88μs	35ns	136ns	0	3.69 KB
master	`ObjectExtractorMoreComplexBody`	net472	6.74μs	3.45ns	13.3ns	0.573	3.8 KB
#7767	`AllCycleSimpleBody`	net6.0	1.07μs	1.04ns	4.05ns	0	1.22 KB
#7767	`AllCycleSimpleBody`	netcoreapp3.1	1.42μs	3.06ns	11.9ns	0	1.2 KB
#7767	`AllCycleSimpleBody`	net472	1.03μs	5.04ns	20.2ns	0.193	1.23 KB
#7767	`AllCycleMoreComplexBody`	net6.0	7.55μs	38.5ns	177ns	0	4.72 KB
#7767	`AllCycleMoreComplexBody`	netcoreapp3.1	8.99μs	4.21ns	15.7ns	0	4.62 KB
#7767	`AllCycleMoreComplexBody`	net472	7.57μs	4.13ns	15.4ns	0.721	4.74 KB
#7767	`ObjectExtractorSimpleBody`	net6.0	316ns	1.81ns	13.9ns	0	280 B
#7767	`ObjectExtractorSimpleBody`	netcoreapp3.1	406ns	1.69ns	5.86ns	0	272 B
#7767	`ObjectExtractorSimpleBody`	net472	305ns	0.0744ns	0.288ns	0.0431	281 B
#7767	`ObjectExtractorMoreComplexBody`	net6.0	6.27μs	10.9ns	40.7ns	0	3.78 KB
#7767	`ObjectExtractorMoreComplexBody`	netcoreapp3.1	7.64μs	38.6ns	173ns	0	3.69 KB
#7767	`ObjectExtractorMoreComplexBody`	net472	6.8μs	4.52ns	17.5ns	0.58	3.8 KB

Benchmarks.Trace.Asm.AppSecEncoderBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EncodeArgs`	net6.0	76.4μs	266ns	997ns	0	32.4 KB
master	`EncodeArgs`	netcoreapp3.1	96.6μs	157ns	609ns	0	32.4 KB
master	`EncodeArgs`	net472	109μs	21.1ns	81.7ns	4.94	32.51 KB
master	`EncodeLegacyArgs`	net6.0	143μs	208ns	806ns	0	2.14 KB
master	`EncodeLegacyArgs`	netcoreapp3.1	196μs	112ns	388ns	0	2.14 KB
master	`EncodeLegacyArgs`	net472	264μs	47.7ns	185ns	0	2.16 KB
#7767	`EncodeArgs`	net6.0	77.8μs	166ns	642ns	0	32.4 KB
#7767	`EncodeArgs`	netcoreapp3.1	98μs	131ns	505ns	0	32.4 KB
#7767	`EncodeArgs`	net472	109μs	81.3ns	315ns	4.92	32.5 KB
#7767	`EncodeLegacyArgs`	net6.0	143μs	8.11ns	30.3ns	0	2.15 KB
#7767	`EncodeLegacyArgs`	netcoreapp3.1	197μs	263ns	1.02μs	0	2.14 KB
#7767	`EncodeLegacyArgs`	net472	264μs	46.5ns	180ns	0	2.16 KB

Benchmarks.Trace.Asm.AppSecWafBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Allocated
master	`RunWafRealisticBenchmark`	net6.0	430μs	1.17μs	4.55μs	4.56 KB
master	`RunWafRealisticBenchmark`	netcoreapp3.1	411μs	169ns	609ns	4.48 KB
master	`RunWafRealisticBenchmark`	net472	457μs	48.3ns	187ns	4.66 KB
master	`RunWafRealisticBenchmarkWithAttack`	net6.0	309μs	74ns	277ns	2.24 KB
master	`RunWafRealisticBenchmarkWithAttack`	netcoreapp3.1	296μs	109ns	421ns	2.22 KB
master	`RunWafRealisticBenchmarkWithAttack`	net472	335μs	40.7ns	158ns	2.29 KB
#7767	`RunWafRealisticBenchmark`	net6.0	394μs	79ns	306ns	4.55 KB
#7767	`RunWafRealisticBenchmark`	netcoreapp3.1	416μs	851ns	3.3μs	4.48 KB
#7767	`RunWafRealisticBenchmark`	net472	428μs	61.2ns	237ns	4.66 KB
#7767	`RunWafRealisticBenchmarkWithAttack`	net6.0	286μs	31.5ns	118ns	2.24 KB
#7767	`RunWafRealisticBenchmarkWithAttack`	netcoreapp3.1	298μs	197ns	712ns	2.22 KB
#7767	`RunWafRealisticBenchmarkWithAttack`	net472	309μs	30.5ns	118ns	2.29 KB

Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Allocated
master	`SendRequest`	net6.0	60.7μs	62.6ns	234ns	14.52 KB
master	`SendRequest`	netcoreapp3.1	71μs	118ns	440ns	17.42 KB
master	`SendRequest`	net472	0.00285ns	0.000927ns	0.00359ns	0 b
#7767	`SendRequest`	net6.0	61.2μs	46.9ns	176ns	14.52 KB
#7767	`SendRequest`	netcoreapp3.1	72.3μs	128ns	462ns	17.42 KB
#7767	`SendRequest`	net472	0.00129ns	0.00092ns	0.00356ns	0 b

Benchmarks.Trace.CharSliceBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`OriginalCharSlice`	net6.0	1.95ms	249ns	962ns	0	640.01 KB
master	`OriginalCharSlice`	netcoreapp3.1	2.07ms	6.45μs	25μs	0	640 KB
master	`OriginalCharSlice`	net472	2.74ms	241ns	931ns	100	641.95 KB
master	`OptimizedCharSlice`	net6.0	1.39ms	651ns	2.52μs	0	6 B
master	`OptimizedCharSlice`	netcoreapp3.1	1.64ms	381ns	1.47μs	0	1 B
master	`OptimizedCharSlice`	net472	1.97ms	248ns	960ns	0	73 B
master	`OptimizedCharSliceWithPool`	net6.0	800μs	31.8ns	123ns	0	3 B
master	`OptimizedCharSliceWithPool`	netcoreapp3.1	852μs	34.9ns	135ns	0	1 B
master	`OptimizedCharSliceWithPool`	net472	1.14ms	73ns	273ns	0	47 B
#7767	`OriginalCharSlice`	net6.0	1.93ms	2.93μs	10.6μs	0	640.01 KB
#7767	`OriginalCharSlice`	netcoreapp3.1	2.15ms	5.27μs	19.7μs	0	640 KB
#7767	`OriginalCharSlice`	net472	2.62ms	373ns	1.4μs	100	641.95 KB
#7767	`OptimizedCharSlice`	net6.0	1.34ms	482ns	1.86μs	0	6 B
#7767	`OptimizedCharSlice`	netcoreapp3.1	1.71ms	605ns	2.34μs	0	1 B
#7767	`OptimizedCharSlice`	net472	2.02ms	664ns	2.57μs	0	73 B
#7767	`OptimizedCharSliceWithPool`	net6.0	799μs	46.8ns	175ns	0	3 B
#7767	`OptimizedCharSliceWithPool`	netcoreapp3.1	810μs	103ns	397ns	0	1 B
#7767	`OptimizedCharSliceWithPool`	net472	1.15ms	102ns	393ns	0	47 B

Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ Fewer allocations 🎉

Fewer allocations 🎉 in #7767

Benchmark	Base Allocated	Diff Allocated	Change	Change %
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces‑net472	55.96 KB	55.61 KB	-347 B	-0.62%

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`WriteAndFlushEnrichedTraces`	net6.0	727μs	3.77μs	17.3μs	0	42.14 KB
master	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	718μs	4.17μs	34.6μs	0	41.75 KB
master	`WriteAndFlushEnrichedTraces`	net472	892μs	3.83μs	14.8μs	4.46	55.96 KB
#7767	`WriteAndFlushEnrichedTraces`	net6.0	714μs	1.68μs	6.06μs	0	42.07 KB
#7767	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	786μs	4.12μs	21.4μs	0	41.82 KB
#7767	`WriteAndFlushEnrichedTraces`	net472	865μs	1.38μs	5.17μs	4.46	55.61 KB

Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Allocated
master	`ExecuteNonQuery`	net6.0	1.88μs	1.54ns	5.97ns	0	0	1.02 KB
master	`ExecuteNonQuery`	netcoreapp3.1	2.62μs	12.1ns	46.8ns	0	0	1.02 KB
master	`ExecuteNonQuery`	net472	2.87μs	4.85ns	17.5ns	0.144	0.0144	987 B
#7767	`ExecuteNonQuery`	net6.0	1.88μs	10.2ns	38.3ns	0	0	1.02 KB
#7767	`ExecuteNonQuery`	netcoreapp3.1	2.61μs	10.3ns	39.8ns	0	0	1.02 KB
#7767	`ExecuteNonQuery`	net472	2.87μs	5.56ns	21.5ns	0.145	0.0145	987 B

Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`CallElasticsearch`	net6.0	1.69μs	8.99ns	44.9ns	0	1.03 KB
master	`CallElasticsearch`	netcoreapp3.1	2.21μs	11.2ns	51.5ns	0	1.03 KB
master	`CallElasticsearch`	net472	3.59μs	1.43ns	5.36ns	0.162	1.04 KB
master	`CallElasticsearchAsync`	net6.0	1.8μs	0.962ns	3.6ns	0	1.01 KB
master	`CallElasticsearchAsync`	netcoreapp3.1	2.33μs	11.3ns	46.6ns	0	1.08 KB
master	`CallElasticsearchAsync`	net472	3.63μs	1.7ns	6.57ns	0.163	1.1 KB
#7767	`CallElasticsearch`	net6.0	1.69μs	2.82ns	10.9ns	0	1.03 KB
#7767	`CallElasticsearch`	netcoreapp3.1	2.18μs	8.98ns	33.6ns	0	1.03 KB
#7767	`CallElasticsearch`	net472	3.66μs	4.04ns	15.6ns	0.164	1.04 KB
#7767	`CallElasticsearchAsync`	net6.0	1.86μs	1.61ns	5.81ns	0	1.01 KB
#7767	`CallElasticsearchAsync`	netcoreapp3.1	2.42μs	9.9ns	38.3ns	0	1.08 KB
#7767	`CallElasticsearchAsync`	net472	3.71μs	1.51ns	5.64ns	0.167	1.1 KB

Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`ExecuteAsync`	net6.0	1.97μs	1.77ns	6.84ns	0	952 B
master	`ExecuteAsync`	netcoreapp3.1	2.44μs	9.56ns	37ns	0	952 B
master	`ExecuteAsync`	net472	2.68μs	7.96ns	30.8ns	0.134	915 B
#7767	`ExecuteAsync`	net6.0	1.87μs	1.86ns	6.71ns	0	952 B
#7767	`ExecuteAsync`	netcoreapp3.1	2.42μs	10.6ns	39.7ns	0	952 B
#7767	`ExecuteAsync`	net472	2.67μs	5.54ns	21.5ns	0.145	915 B

Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`SendAsync`	net6.0	7.06μs	19.8ns	76.7ns	0	2.36 KB
master	`SendAsync`	netcoreapp3.1	8.87μs	24.7ns	92.4ns	0	2.9 KB
master	`SendAsync`	net472	12.6μs	10.7ns	41.5ns	0.504	3.18 KB
#7767	`SendAsync`	net6.0	6.91μs	9.67ns	36.2ns	0	2.36 KB
#7767	`SendAsync`	netcoreapp3.1	8.74μs	34ns	132ns	0	2.9 KB
#7767	`SendAsync`	net472	12.3μs	7.83ns	29.3ns	0.492	3.18 KB

Benchmarks.Trace.Iast.StringAspectsBenchmark - Slower ⚠️ Fewer allocations 🎉

Slower ⚠️ in #7767

Benchmark	diff/base	Base Median (ns)	Diff Median (ns)	Modality
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark‑net6.0	1.130	455,300.00	514,600.00

Faster 🎉 in #7767

Benchmark	base/diff	Base Median (ns)	Diff Median (ns)	Modality
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatBenchmark‑net6.0	1.158	47,300.00	40,850.00

Fewer allocations 🎉 in #7767

Benchmark	Base Allocated	Diff Allocated	Change	Change %
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatBenchmark‑netcoreapp3.1	43.14 KB	42.78 KB	-360 B	-0.83%
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatBenchmark‑net6.0	45.34 KB	44.53 KB	-816 B	-1.80%
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark‑net472	286.72 KB	278.53 KB	-8.19 KB	-2.86%

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Allocated
master	`StringConcatBenchmark`	net6.0	48.1μs	306ns	2.95μs	45.34 KB
master	`StringConcatBenchmark`	netcoreapp3.1	50.9μs	391ns	3.71μs	43.14 KB
master	`StringConcatBenchmark`	net472	58.3μs	117ns	438ns	57.34 KB
master	`StringConcatAspectBenchmark`	net6.0	458μs	1.33μs	4.78μs	260.24 KB
master	`StringConcatAspectBenchmark`	netcoreapp3.1	508μs	2.28μs	8.83μs	256.27 KB
master	`StringConcatAspectBenchmark`	net472	399μs	1.7μs	6.58μs	286.72 KB
#7767	`StringConcatBenchmark`	net6.0	41.1μs	158ns	568ns	44.53 KB
#7767	`StringConcatBenchmark`	netcoreapp3.1	50.8μs	314ns	2.99μs	42.78 KB
#7767	`StringConcatBenchmark`	net472	56.5μs	238ns	1.01μs	57.34 KB
#7767	`StringConcatAspectBenchmark`	net6.0	514μs	1.86μs	6.7μs	261.25 KB
#7767	`StringConcatAspectBenchmark`	netcoreapp3.1	510μs	2.72μs	14.4μs	256.14 KB
#7767	`StringConcatAspectBenchmark`	net472	400μs	2.13μs	16.1μs	278.53 KB

Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	2.65μs	0.571ns	2.21ns	0	1.7 KB
master	`EnrichedLog`	netcoreapp3.1	3.65μs	14.5ns	54.2ns	0	1.7 KB
master	`EnrichedLog`	net472	3.81μs	3.36ns	13ns	0.248	1.64 KB
#7767	`EnrichedLog`	net6.0	2.66μs	12.5ns	48.4ns	0	1.7 KB
#7767	`EnrichedLog`	netcoreapp3.1	3.82μs	13.9ns	52.1ns	0	1.7 KB
#7767	`EnrichedLog`	net472	4.01μs	5.88ns	22.8ns	0.241	1.64 KB

Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Allocated
master	`EnrichedLog`	net6.0	128μs	606ns	2.5μs	4.31 KB
master	`EnrichedLog`	netcoreapp3.1	132μs	463ns	1.79μs	4.31 KB
master	`EnrichedLog`	net472	175μs	444ns	1.72μs	4.51 KB
#7767	`EnrichedLog`	net6.0	124μs	103ns	400ns	4.31 KB
#7767	`EnrichedLog`	netcoreapp3.1	129μs	287ns	1.03μs	4.31 KB
#7767	`EnrichedLog`	net472	170μs	131ns	491ns	4.52 KB

Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	4.99μs	6.8ns	26.3ns	0	2.26 KB
master	`EnrichedLog`	netcoreapp3.1	6.87μs	8.36ns	32.4ns	0	2.26 KB
master	`EnrichedLog`	net472	7.63μs	5.06ns	18.9ns	0.304	2.08 KB
#7767	`EnrichedLog`	net6.0	5.04μs	8.44ns	31.6ns	0	2.26 KB
#7767	`EnrichedLog`	netcoreapp3.1	6.88μs	14.7ns	57.1ns	0	2.26 KB
#7767	`EnrichedLog`	net472	7.77μs	7.2ns	27.9ns	0.312	2.08 KB

Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`SendReceive`	net6.0	2.06μs	6.65ns	25.8ns	0	1.2 KB
master	`SendReceive`	netcoreapp3.1	2.63μs	12.5ns	48.5ns	0	1.2 KB
master	`SendReceive`	net472	3.03μs	6.35ns	24.6ns	0.18	1.2 KB
#7767	`SendReceive`	net6.0	2.05μs	1.48ns	5.74ns	0	1.2 KB
#7767	`SendReceive`	netcoreapp3.1	2.65μs	12.8ns	54.3ns	0	1.2 KB
#7767	`SendReceive`	net472	3.07μs	3.43ns	13.3ns	0.184	1.2 KB

Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	4.27μs	15.3ns	57.1ns	0	1.58 KB
master	`EnrichedLog`	netcoreapp3.1	5.83μs	14.6ns	56.4ns	0	1.63 KB
master	`EnrichedLog`	net472	6.63μs	7.92ns	30.7ns	0.297	2.03 KB
#7767	`EnrichedLog`	net6.0	4.21μs	12.6ns	48.9ns	0	1.58 KB
#7767	`EnrichedLog`	netcoreapp3.1	5.61μs	11.1ns	43.2ns	0	1.63 KB
#7767	`EnrichedLog`	net472	6.52μs	15.7ns	60.7ns	0.29	2.03 KB

Benchmarks.Trace.SpanBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`StartFinishSpan`	net6.0	772ns	3.4ns	12.7ns	0	576 B
master	`StartFinishSpan`	netcoreapp3.1	998ns	4.54ns	18.2ns	0	576 B
master	`StartFinishSpan`	net472	958ns	0.106ns	0.396ns	0.0911	578 B
master	`StartFinishScope`	net6.0	953ns	1.49ns	5.79ns	0	696 B
master	`StartFinishScope`	netcoreapp3.1	1.22μs	0.707ns	2.74ns	0	696 B
master	`StartFinishScope`	net472	1.17μs	2.6ns	10.1ns	0.1	658 B
#7767	`StartFinishSpan`	net6.0	823ns	3.07ns	11.9ns	0	576 B
#7767	`StartFinishSpan`	netcoreapp3.1	973ns	0.521ns	2.02ns	0	576 B
#7767	`StartFinishSpan`	net472	942ns	0.801ns	3.1ns	0.09	578 B
#7767	`StartFinishScope`	net6.0	918ns	5.19ns	33.6ns	0	696 B
#7767	`StartFinishScope`	netcoreapp3.1	1.2μs	6.26ns	29.3ns	0	696 B
#7767	`StartFinishScope`	net472	1.13μs	0.577ns	2.24ns	0.101	658 B

Benchmarks.Trace.TraceAnnotationsBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`RunOnMethodBegin`	net6.0	1.07μs	5.12ns	21.7ns	0	696 B
master	`RunOnMethodBegin`	netcoreapp3.1	1.4μs	0.489ns	1.9ns	0	696 B
master	`RunOnMethodBegin`	net472	1.44μs	0.501ns	1.87ns	0.101	658 B
#7767	`RunOnMethodBegin`	net6.0	1.06μs	4.72ns	17.7ns	0	696 B
#7767	`RunOnMethodBegin`	netcoreapp3.1	1.44μs	6.51ns	24.4ns	0	696 B
#7767	`RunOnMethodBegin`	net472	1.44μs	0.541ns	2.1ns	0.101	658 B

…)" (#7704) This reverts commit b59dea4.

lucaspimentel requested review from a team as code owners November 3, 2025 23:10

lucaspimentel added type:enhancement Improvement to an existing feature area:configuration labels Nov 3, 2025

chatgpt-codex-connector bot reviewed Nov 3, 2025

View reviewed changes

tracer/src/Datadog.Trace.ClrProfiler.Managed.Loader/Startup.cs Show resolved Hide resolved

andrewlock approved these changes Nov 4, 2025

View reviewed changes

bouwkast approved these changes Nov 4, 2025

View reviewed changes

lucaspimentel force-pushed the lpimentel/remove-tracer-home-dependency-redux branch from ab2ab63 to 2dbbeaf Compare November 7, 2025 22:27

gleocadie and others added 3 commits November 10, 2025 08:59

Rewrite test to make it clear

eeed53a

Fix flaky contention test

006eeae

Reapply "make DD_DOTNET_TRACER_HOME optional in managed loader (#7568…

fd6e208

…)" (#7704) This reverts commit b59dea4.

lucaspimentel force-pushed the lpimentel/remove-tracer-home-dependency-redux branch from 2dbbeaf to fd6e208 Compare November 10, 2025 15:51

lucaspimentel requested a review from a team as a code owner November 10, 2025 15:51

Reapply "make DD_DOTNET_TRACER_HOME optional in managed loader" #7767

Are you sure you want to change the base?

Reapply "make DD_DOTNET_TRACER_HOME optional in managed loader" #7767

Conversation

lucaspimentel commented Nov 3, 2025

Summary of changes

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

dd-trace-dotnet-ci-bot bot commented Nov 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Execution-Time Benchmarks Report ⏱️

FakeDbCommand

HttpMessageHandler

Uh oh!

andrewlock left a comment

Choose a reason for hiding this comment

Uh oh!

datadog-datadog-prod-us1 bot commented Nov 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ Warnings

ℹ️ Info

Uh oh!

pr-commenter bot commented Nov 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Benchmarks

Benchmarks Report for benchmark platform 🐌

Benchmark details

More allocations ⚠️ in #7767

Raw results

Fewer allocations 🎉 in #7767

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Fewer allocations 🎉 in #7767

Raw results

Raw results

Raw results

Raw results

Raw results

Slower ⚠️ in #7767

Faster 🎉 in #7767

Fewer allocations 🎉 in #7767

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Reapply "make `DD_DOTNET_TRACER_HOME` optional in managed loader" #7767

Reapply "make `DD_DOTNET_TRACER_HOME` optional in managed loader" #7767

dd-trace-dotnet-ci-bot bot commented Nov 3, 2025 •

edited

Loading

datadog-datadog-prod-us1 bot commented Nov 5, 2025 •

edited

Loading

pr-commenter bot commented Nov 7, 2025 •

edited

Loading