-
Notifications
You must be signed in to change notification settings - Fork 483
draft: implement v1 trace protocol serialization #3947
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: hannahkm/msgp-payload-interface
Are you sure you want to change the base?
draft: implement v1 trace protocol serialization #3947
Conversation
- Added msgp struct tags to fields in payloadV1 and traceChunk for serialization. - Introduced EncodeMsg methods for payloadV1 and spanListV1 to support msgp encoding. - Updated field types in traceChunk to enhance compatibility with msgp serialization.
BenchmarksBenchmark execution time: 2025-09-29 19:12:00 Comparing candidate commit a12502c in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 24 metrics, 0 unstable metrics. |
|
ddtrace/tracer/payload_v1.go
Outdated
} | ||
|
||
type stringTable struct { | ||
m sync.Mutex |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not aware of any concurrent serialization going over the same span. Do we need this?
// } | ||
if protocol == traceProtocolV1 { | ||
return &safePayload{ | ||
p: newPayloadV1(), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Beyond the linter errors, this is looking in the right direction.
What does this PR do?
Implements the v1 trace protocol. Includes commits cherry-picked from #3932 since I closed my previous PR.
Motivation
https://datadoghq.atlassian.net/browse/LANGPLAT-750
Reviewer's Checklist
./scripts/lint.sh
locally.Unsure? Have a question? Request a review!