feat(aws): add partition tag #3966
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds a
aws.partition
tag onto AWS traces based on the region. The logic to derive this partition is identical to what we do within the SQS arn extraction logic we added earlier.Motivation
Part of a larger effort to better link cloud resources within Datadog. We often need the AWS partition during downstream enrichment - it is almost always a required part of constructing an ARN, but it's currently not captured in the library
Jira Ticket and more context around this effort
Reviewer's Checklist
./scripts/lint.sh
locally.Unsure? Have a question? Request a review!