Skip to content

Conversation

jackgopack4
Copy link

What does this PR do?

fix go get -u failure first seen here

Motivation

https://app.datadoghq.com/incidents/43109

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • New code is free of linting errors. You can check this by running ./scripts/lint.sh locally.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.

Unsure? Have a question? Request a review!

@github-actions github-actions bot added the apm:ecosystem contrib/* related feature requests or bugs label Sep 16, 2025
@jackgopack4 jackgopack4 changed the title [chore] bump datadog-agent v0.71.0-rc.2 #incident-43109 chore: bump datadog-agent v0.71.0-rc.2 #incident-43109 Sep 16, 2025
@jackgopack4 jackgopack4 added bug unintended behavior that has to be fixed dependencies Pull requests that update a dependency file labels Sep 16, 2025
@jackgopack4 jackgopack4 marked this pull request as ready for review September 16, 2025 13:18
@pr-commenter
Copy link

pr-commenter bot commented Sep 16, 2025

Benchmarks

Benchmark execution time: 2025-09-16 21:01:47

Comparing candidate commit 2683330 in PR branch jackgopack4/bump-datadog-agent-v0.71.0-rc.2 with baseline commit a42a2ba in branch main.

Found 0 performance improvements and 1 performance regressions! Performance is the same for 2 metrics, 0 unstable metrics.

scenario:BenchmarkSetTagStringPtr-24

  • 🟥 execution_time [+3.621ns; +7.859ns] or [+2.549%; +5.532%]

Copy link
Contributor

datadog-official bot commented Sep 16, 2025

✅ Tests

🎉 All green!

❄️ No new flaky tests detected
🧪 All tests passed

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 2683330 | Docs | Was this helpful? Give us feedback!

@darccio
Copy link
Member

darccio commented Sep 16, 2025

@jackgopack4 This PR can fix the issue, but introducing a lot of changes urgently doesn't feel adequate. The breaking CI pipeline is smoke-tests, so it's quite isolated. Tagging a non-release candidate would fix it.

@jackgopack4
Copy link
Author

@darccio thanks, will take a closer look.

@jackgopack4 jackgopack4 marked this pull request as draft September 16, 2025 14:19
@jackgopack4 jackgopack4 marked this pull request as ready for review September 16, 2025 14:50
@jackgopack4 jackgopack4 force-pushed the jackgopack4/bump-datadog-agent-v0.71.0-rc.2 branch 2 times, most recently from 99da0e2 to 9c366cc Compare September 16, 2025 20:03
@jackgopack4 jackgopack4 requested a review from a team as a code owner September 16, 2025 20:12
@jackgopack4 jackgopack4 marked this pull request as draft September 16, 2025 20:18
@jackgopack4
Copy link
Author

go get -u seems to be bumping now to v0.72.0-devel which has a bunch of bad version numbers as dependencies.

@jackgopack4 jackgopack4 force-pushed the jackgopack4/bump-datadog-agent-v0.71.0-rc.2 branch from 12d84ad to a7ccba0 Compare September 16, 2025 20:28
@jackgopack4
Copy link
Author

yeah it seems like the go get -u upgrades to 72.0-devel when it's on an rc tag, so this won't be sustainable approach

@jackgopack4 jackgopack4 force-pushed the jackgopack4/bump-datadog-agent-v0.71.0-rc.2 branch from a7ccba0 to 2683330 Compare September 16, 2025 20:58
@stevesim101
Copy link

Just wondering if there is an ETA on this.........starting to see this impact go project builds at my company that utilize Datadog tracing.

@darccio
Copy link
Member

darccio commented Sep 24, 2025

@stevesim101 This issue only impacts your projects if you run go get -u. We advise to prefer targeted upgrades, probably relying on tooling like Dependabot or Renovate.

We understand it's not convenient, but blanket upgrades are discouraged because other dependencies outside of Datadog organization may also introduce breaking changes from time to time: #3779 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
apm:ecosystem contrib/* related feature requests or bugs bug unintended behavior that has to be fixed dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants