-
Notifications
You must be signed in to change notification settings - Fork 490
fix: Fix duplicate and out-of-order key in supported_configurations #4121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Fix duplicate and out-of-order key in supported_configurations #4121
Conversation
BenchmarksBenchmark execution time: 2025-11-13 16:42:58 Comparing candidate commit b333831 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 23 metrics, 1 unstable metrics. |
|
✅ Tests 🎉 All green!❄️ No new flaky tests detected 🔗 Commit SHA: b333831 | Docs | Datadog PR Page | Was this helpful? Give us feedback! |
| "DD_TRACE_128_BIT_TRACEID_LOGGING_ENABLED": {}, | ||
| "DD_TRACE_ABANDONED_SPAN_TIMEOUT": {}, | ||
| "DD_TRACE_AGENT_PORT": {}, | ||
| "DD_TRACE_V1_PAYLOAD_FORMAT_ENABLED": {}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The generation script moves this key to be in lexicographical order.
This change was made by running go run ./scripts/configinverter/main.go generate
| "DD_TRACE_VAULT_ANALYTICS_ENABLED": [ | ||
| "A" | ||
| ], | ||
| "DD_TRACE_V1_PAYLOAD_FORMAT_ENABLED": [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This duplicate key, which also appears on 615, is removed by running make test.
|
/merge |
|
View all feedbacks in Devflow UI.
This pull request is not mergeable according to GitHub. Common reasons include pending required checks, missing approvals, or merge conflicts — but it could also be blocked by other repository rules or settings.
The expected merge time in
Tests failed on this commit fbebbbc: What to do next?
|
|
test_core is failing 3/4 times. Unrelated /merge |
|
/merge |
|
View all feedbacks in Devflow UI.
The expected merge time in
|
Merge activity
|

What does this PR do?
Fixes
main by fixing duplicate and disordered keys in env var files.Motivation
This was causing failures on my other branch not attributable to my changes #4100 and causing confusion
Reviewer's Checklist
./scripts/lint.shlocally.Unsure? Have a question? Request a review!