Skip to content

Conversation

dkirov-dd
Copy link
Contributor

@dkirov-dd dkirov-dd commented Sep 5, 2025

What does this PR do?

Add filesystem, jobid_var and jobid_name tags to metrics that support them.

Motivation

This will allow more granular analysis for HPC.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Add the qa/skip-qa label if the PR doesn't need to be tested during QA.
  • If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

Copy link

codecov bot commented Sep 8, 2025

Codecov Report

❌ Patch coverage is 89.39394% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 89.02%. Comparing base (009042b) to head (e8cfd0e).
⚠️ Report is 63 commits behind head on master.

Additional details and impacted files
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dkirov-dd dkirov-dd marked this pull request as ready for review September 8, 2025 13:35
@dkirov-dd dkirov-dd requested a review from a team as a code owner September 8, 2025 13:35
Copy link

@vksrinivasan1 vksrinivasan1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@dkirov-dd dkirov-dd added this pull request to the merge queue Sep 16, 2025
Merged via the queue into master with commit a45b1c5 Sep 16, 2025
33 checks passed
@dkirov-dd dkirov-dd deleted the dk/AI-6111/lustre-add-tags branch September 16, 2025 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants