[CNM-4887][network_path] Add Skipped Conns widget #21831
Conversation
AlexandreYang
changed the title
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| "queries": [ | ||
| { | ||
| "data_source": "metrics", | ||
| "name": "query2", | ||
| "query": "sum:datadog.network_path.collector.raw_connections_chan_size{$host,$datacenter,$cluster_name} by {cluster_name,datacenter}.weighted()" | ||
| } |
There was a problem hiding this comment.
.weighted() queries
The new internal channel widgets call queries like sum:datadog.network_path.collector.raw_connections_chan_size{…}.weighted() without providing the weight series. The Datadog query language does not allow a bare .weighted() suffix, so the widget will render an error instead of data. The same issue occurs for input_chan_size and processing_chan_size further down. Either drop the .weighted() call or supply a proper numerator/denominator expression.
Useful? React with 👍 / 👎.
| { | ||
| "data_source": "metrics", | ||
| "name": "query2", | ||
| "query": "sum:datadog.network_path.collector.raw_connections_chan_size{$host,$datacenter,$cluster_name} by {cluster_name,datacenter}.weighted()" |
There was a problem hiding this comment.
I'm not seeing this metric exist anywhere in prod or staging: [Link to staging] Is this going to be added in the future?
What does this PR do?
[network_path] Add Skipped Conns widget
Motivation
Review checklist (to be filled by reviewers)
qa/skip-qalabel if the PR doesn't need to be tested during QA.backport/<branch-name>label to the PR and it will automatically open a backport PR once this one is merged