Upgrade mediawiki-codesniffer to latest version (45.0.0) #63
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JeroenDeDauw
reviewed
Dec 6, 2024
JeroenDeDauw
reviewed
Dec 6, 2024
| * @param string|null $expectedFormat An identifier for the format the raw value did not match | ||
| */ | ||
| public function __construct( string $message, string $rawValue = null, string $expectedFormat = null ) { | ||
| public function __construct( string $message, ?string $rawValue = null, ?string $expectedFormat = null ) { |
There was a problem hiding this comment.
JeroenDeDauw
reviewed
Dec 6, 2024
|
CI fails. Suggested fix: drop runs under PHP 7.4 and update PHP requirement in composer.json to match |
This was referenced Dec 6, 2024
This repository is currently using version 34 of the Mediawiki coding style phpcs rules. If the code aims to comply with Mediawiki style guidelines, it makes sense that it continues to comply at current versions of the rules. Besides being simply different, the newer versions of the rules introduce, for example, MediaWiki.Usage.NullableType.ExplicitNullableTypes, which enforces compliance with coming deprecation rules in PHP 8.4 concerning nullable types. If the code does not remove the soon-to-be-deprecated form of nullable type declarations, the library will no longer be usable in Mediawiki for PHP 8.4 deployments. Resolves DataValues#62 Bug: T379481
codders
force-pushed
the
feat/upgrade-mediawiki-codesniffer-20241206
branch
from
8a558b8 to
ae70d19
Compare
|
I've updated the version requirement and amended the PR based on your feedback. Thanks for the input! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This repository is currently using version 34 of the Mediawiki coding style phpcs rules. If the code aims to comply with Mediawiki style guidelines, it makes sense that it continues to comply at current versions of the rules.
Besides being simply different, the newer versions of the rules introduce, for example,
MediaWiki.Usage.NullableType.ExplicitNullableTypes, which enforces compliance with coming deprecation rules in PHP 8.4 concerning nullable types. If the code does not remove the soon-to-be-deprecated form of nullable type declarations, the library will no longer be usable in Mediawiki for PHP 8.4 deployments.
Resolves #62
Bug: T379481