Skip to content

Avoid accidental replacement of main DB model connections #98

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Avoid accidental replacement of main DB model connections #98

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions lib/database_cleaner/active_record/base.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,8 +84,11 @@ def lookup_from_connection_pool
end

def establish_connection
::ActiveRecord::Base.establish_connection(connection_hash)
::ActiveRecord::Base
# creates a temporary ActiveRecord class that is unique to connection_hash
ActiveRecord.module_eval("class Temp#{connection_hash.hash.abs} < ::ActiveRecord::Base; self; end")
.tap { |ar_class|
ar_class.establish_connection(connection_hash)
}
end

def database_for(model)
Expand Down
3 changes: 2 additions & 1 deletion spec/database_cleaner/active_record/base_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,7 +166,8 @@ module ActiveRecord

it "establishes a connection with it" do
expect(::ActiveRecord::Base).to receive(:establish_connection).with(hash)
expect(strategy.connection_class).to eq ::ActiveRecord::Base
expect(strategy.connection_class).to be < ::ActiveRecord::Base
expect(strategy.connection_class.name).to match /^DatabaseCleaner::ActiveRecord::Temp\d+$/
end
end

Expand Down