feat(plugins/layerChooser): migrate plugin #358
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dopenguin
added
enhancement
…sk layers Tooltip when a layer is disabled is missing and will follow in an upcoming commit.
…mespace for the locales
…-layer-chooser # Conflicts: # examples/iceberg/App.vue # examples/snowbox/AnotherEmptyComponent.vue # examples/snowbox/index.js # src/core/components/PolarMap.ce.vue # src/core/components/layouts/NineLayout.ce.vue # src/core/components/layouts/StandardLayout.ce.vue # src/core/index.ts # src/core/stores/main.ts # src/core/types/plugin.ts # src/plugins/fullscreen/components/FullscreenUI.ce.vue
Member
Author
|
@oeninghe-dataport I had to add The PR is now ready for review. |
Collaborator
|
Loosely related: #386 |
Co-authored-by: Hendrik Oenings <[email protected]>
Co-authored-by: Hendrik Oenings <[email protected]>
…of using a setter
Co-authored-by: Hendrik Oenings <[email protected]>
Member
Author
Member
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Migrate LayerChooser plugin to @polar/polar and implement reusable components
PolarCard,PolarInputandPolarInputGroup.Instructions for local reproduction and review
Snowbox provides the LayerChooser as part of the IconMenu for layout ninenRegions and standard.
Relevant tickets, issues, et cetera
Closes #346, Blocked by #357 and #364