Skip to content

feat(plugins/pins): migrate plugin #374

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 32 commits into
base: next
Choose a base branch
from
Open

feat(plugins/pins): migrate plugin #374

wants to merge 32 commits into from

Conversation

@dopenguin
Copy link
Member

@dopenguin dopenguin commented Sep 29, 2025 •
edited
Loading

Summary

Migrate Pins plugin to @polar/polar.

Instructions for local reproduction and review

  • npm run snowbox
  • Click anywhere in the map
  • A pin should now be visible
  • If you click outside the boundary of Hamburg or try to drag the pin outside of the boundary, a toast should be displayed and the pin should be in it's previous location

Relevant tickets, issues, et cetera

Closes #352

If #366 is merged before this PR, then the PinsOptions should be extended by LayerBoundPluginOptions. Otherwise, this change has to be added to #366.

Blocked by #404

@dopenguin dopenguin added this to the POLAR@3 milestone Sep 29, 2025
@dopenguin dopenguin self-assigned this Sep 29, 2025
@dopenguin dopenguin added enhancement New feature or request refactor Refactoring of previous code labels Sep 29, 2025
@dopenguin dopenguin mentioned this pull request Oct 21, 2025
Merged
dopenguin and others added 15 commits October 21, 2025 11:14
@dopenguin
Merge branch 'vue3/migrate-lib-passes-boundary-check' into vue3/migra…
eabad28 
…te-plugin-pins

# Conflicts:
#	src/core/types/plugin.ts
@dopenguin
refactor: add pins resources to type
5d7ea96
@dopenguin
fix(pins): add missing empty lines
97c0b9f
@dopenguin
refactor(pins): add implementation to check whether a coordinate is i…
2e2ced5 
…n the boundary of a layer
@dopenguin
refactor(pins): update todo to be tackled later
9f15648
@dopenguin
fix(pins): add missing empty lines
c4550e7
@dopenguin
fix(pins): await calls to isCoordinateInBoundaryLayer and subsequent …
25fcef9 
…functions
@dopenguin
Merge branch 'next' into vue3/migrate-plugin-pins
5895a62
@dopenguin
fix(pins): use relative import to fix cyclic dependency
bb8feca
@dopenguin
Merge branch 'next' into vue3/migrate-plugin-pins
38eec3c
@dopenguin
fix(pins): add missing space
97743b9
@dopenguin
refactor(pins): update configuration parameter coordinateSource to al…
af285b3 
…low multiple sources
@dopenguin
fix(pins): use correct parameter in example
2002afd
@dopenguin
feat(pins): add tsdoc to coordinate
2f6c0d3
@dopenguin
feat(pins): add possibility to configure a different SVG
84aadd5
@dopenguin dopenguin marked this pull request as ready for review October 21, 2025 16:21
dopenguin added a commit that referenced this pull request Oct 21, 2025
@dopenguin
refactor: update boundary type to be equal to the implementation in #374
cea0b0c
@dopenguin dopenguin linked an issue Oct 22, 2025 that may be closed by this pull request
Migration of Pins plugin to POLAR@3 #352
Open
dopenguin and others added 2 commits October 28, 2025 15:47
@dopenguin dopenguin mentioned this pull request Oct 29, 2025
Open
@dopenguin dopenguin mentioned this pull request Nov 12, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@warm-coolguy warm-coolguy Awaiting requested review from warm-coolguy warm-coolguy is a code owner

@oeninghe-dataport oeninghe-dataport Awaiting requested review from oeninghe-dataport oeninghe-dataport is a code owner

Assignees

@dopenguin dopenguin

Labels

enhancement New feature or request refactor Refactoring of previous code

Projects

None yet

Milestone

POLAR@3

Development

Successfully merging this pull request may close these issues.

Migration of Pins plugin to POLAR@3

1 participant

@dopenguin