add reverse geocoder to afm client #382
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
warm-coolguy
requested review from
czirkelbach,
dopenguin and
oeninghe-dataport
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adding the reverse geocoder plugin to the AfM client.
Instructions for local reproduction and review
The plugin has been configured as part of the AfM's example so that the usual usage can be tested. However, in its first use case, the
AddressSearchplugin will probably not be present. Thus, no defaulting configuration has been added, as it may not be desired.Pull Request Checklist (for Assignee)
No real implementation work done, hence the example test seems to suffice to me. Everything else should work by virtue of having working previously.