Add Swift formatting locally and in CI #256
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasikpark
force-pushed
the
ignore-pods-generated-docs-swiftvioe
branch
from
4c9207c to
5d97e53
Compare
|
closing for #261 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/nicklockwood/SwiftFormat automatically formats swift code like how we treat dart and golang.
#254 was a different attempt, but https://github.com/swiftlang/swift-format doesn't support easily ignoring a source folder, and the "is it formatted" command also detects lints.
Refs:
.swiftformatignore, etc to ignorePods/and other folders when recursively formatting swiftlang/swift-format#931There's an option to load the tool via Cocoapods, or Swift Package Manager, but I think just allowing users to install via homebrew, or whichever method they wish is best for now.
The actual CI check is disabled, enabled in #257