Improve usability of the API key overview #1296
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit makes the ApiKeyListGroupItem component more friendly to smaller screen sizes, improving the UX of reviewing issued API keys against a team. Previously, if a window were sized below 1760px wide, the redacted keys, as well as the "Remove, Edit, Regenerate" API Key buttons, would overflow their parent div within the template. These overflows, while mainly a visual defect, could cause multiple buttons to share the same location, hindering accessibility. These changes help ensure that this content is always rendered within the parent div. Regarding key rendering, it seems sensible to only render the publicId portion of the key, as the redaction chars don't seem to add much from a user perspective. Signed-off-by: Darian Culver <[email protected]>
🎉 Snyk checks have passed. No issues have been found so far.✅ security/snyk check is complete. No issues have been found. (View Details) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This MR amends the ApiKeyListGroupItem component to be more friendly to smaller screen sizes.
Prior to this MR, the API Keys within a Teams detail view would 'break out' of their parent div when viewing on smaller screen sizes ( < 1700px ), resulting in a clunky UX.
These overflows, while mainly a visual defect, could cause multiple buttons to share the same location, hindering accessibility.
These changes help ensure that this content is always rendered within the parent div, regardless of screen size.
Addressed Issue
#1295
Additional Details
N/A
Checklist
- [ ] This PR introduces new or alters existing behavior, and I have updated the documentation accordingly