fix 339 #71
Open
fix 339 #71
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danieldanielecki
requested changes
Oct 9, 2025
goncalodasilva
force-pushed
the
patch-28
branch
from
35d643d to
49c2c37
Compare
Done |
S3 bucket policies control access to the S3 bucket and its objects, not to KMS keys. You cannot grant a bucket access to a KMS key through a bucket policy. The principal (EC2 instance/IAM role) needs access to the key, not the bucket itself. KMS key policies are the primary way to control access to KMS keys, and to use IAM policies to control access to a KMS key, the key policy must give the account permission to use IAM policies https://docs.aws.amazon.com/kms/latest/developerguide/key-policies.html https://docs.aws.amazon.com/kms/latest/developerguide/control-access.html
goncalodasilva
force-pushed
the
patch-28
branch
from
49c2c37 to
783d66a
Compare
and in the table of contents? :( |
danieldanielecki
requested changes
Oct 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
S3 bucket policies control access to the S3 bucket and its objects, not to KMS keys. You cannot grant a bucket access to a KMS key through a bucket policy. The principal (EC2 instance/IAM role) needs access to the key, not the bucket itself.
KMS key policies are the primary way to control access to KMS keys, and to use IAM policies to control access to a KMS key, the key policy must give the account permission to use IAM policies
https://docs.aws.amazon.com/kms/latest/developerguide/key-policies.html https://docs.aws.amazon.com/kms/latest/developerguide/control-access.html