Skip to content

Conversation

@remorses
Copy link

Implements #326

@remorses remorses marked this pull request as ready for review August 22, 2022 16:52
@remorses remorses requested a review from Piccirello as a code owner August 22, 2022 16:52
@remorses
Copy link
Author

I can add tests for ReplaceTransformer if you want, i copied that code from here

@Piccirello
Copy link
Contributor

I'm having difficulty understanding the practical use case for this, beyond demos. Why would a user want invalid values to be injected? I think a more pragmatic solution would be to support specifying an allowlist of secrets that should be injected (#322).

@remorses
Copy link
Author

This pr does not inject invalid values, it simply hides them from the terminal output, the env variables remain the same

some use cases

  • Making sure CI logs do not contain secrets (anyone that can see your logs could steal your secrets, very dangerous)
  • streaming on twitch or demos

@benhylak
Copy link

this is nice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants