make location button space for more wide, so it's easy to click on smaller screen d… #1842
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The build.gradle change ideally should be removed from this PR. |
|
@incomingflyingbrick The bottom margin was updated from 5dp to 6dp in the API >= 21. I believe changing just 1dp does not make any noticeable difference. I think it is easier for user to click buttons if we update from -16dp to -6dp in "values/styles.xml" and update 5dp to 15dp in "values-v21/styles.xml" file |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I changed location button spacing a little bit, no logic change.
Sometime i found out that it's very hard to click the right button, because all three button on the left are too close together. (My Location Button, Drone location Button, Sliding Panel Button)