Add RO:0004009 (has_primary_input) relationships to 'response to' EFO terms with CHEBI mappings #2509
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR addresses issue requirements to add
has_primary_input some CHEBI_termaxioms to EFO terms with labels starting with 'response to'. The implementation adds RO:0004009 (has_primary_input) relationships linking response terms to their corresponding CHEBI chemical/drug entities.Changes Made
1. Added RO:0004009 Relationships to 18 Terms
Successfully added
has_primary_inputrelationships to 18 'response to' terms where exact CHEBI matches were found through systematic OLS searches:Drug Classes (13 terms):
Additional Drug Classes (5 terms):
2. Updated CHEBI Import Dependencies
Added 13 new CHEBI term IRIs to
src/ontology/iri_dependencies/chebi_terms.txtfor future import when ontology mirrors can be updated.3. Maintained Ontology Quality
make normalize_srcafter each batch of changesExample Changes
The implementation adds structured OWL restrictions as shown in the issue example:
Scope and Coverage
Many remaining terms don't have direct CHEBI equivalents as they represent complex interventions (exercise, diet, surgery), abstract concepts (disappointment, trauma), multi-component therapies (combination chemotherapy), or specific procedures (cold pressor test, radiation therapy) rather than pure chemical substances.
Next Steps
When network access allows:
./get_mirrors.shto update ontology mirrorsmake imports/chebi_import.owl -BNote on OBA Comment
Per @ar-ibrahim's comment, some EFO 'response to' terms could potentially be replaced with OBA terms using DOSDP patterns. This PR focuses on augmenting existing EFO terms with CHEBI relationships as requested in the issue. The broader architectural question of EFO vs. OBA term usage should be discussed separately with the curation team.
@ai agent
Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
data.monarchinitiative.orgcurl -L REDACTED(dns block)purl.obolibrary.orgcurl -L REDACTED(dns block)If you need me to access, download, or install something from one of these locations, you can either:
Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.