Skip to content

Conversation

cthoyt
Copy link
Contributor

@cthoyt cthoyt commented Jul 21, 2025

Related to #935

This PR extends ShortFormAnnotator.java to handle ad-hoc namespaces in the OBO PURL space that take the form http://purl.obolibrary.org/obo/<lower>#<luid>, such as http://obolibrary.org/obo/mesh#C

This PR will give more accurate short form names that does not rely on implicit capitalization conventions

@cthoyt
Copy link
Contributor Author

cthoyt commented Jul 22, 2025

I wasn't able to find a place to write some unit tests - @haideriqbal could you advise where I can put some?

@haideriqbal
Copy link
Collaborator

@cthoyt we don't have unit tests in OLS, we do manual testing at the moment of comparing the dataload files for different test scenarios...

for this change i will need to do that and will let you know... we are looking into automating the testcases as some point

@cthoyt
Copy link
Contributor Author

cthoyt commented Sep 19, 2025

@haideriqbal I added some unit tests, but I'm not sure the best way to run them/incorporate in CI

@haideriqbal
Copy link
Collaborator

@cthoyt we don't run unit test in traditional sense for OLS. We have a testcases folder where we add specific kind of ontologies to address various OLS use cases. If you can have a look at the folder and formulate a test which depicts this change that will be awesome. Also, have a read through OLS readme to get a gist of how we run the testcases for dataload in OLS.

@cthoyt
Copy link
Contributor Author

cthoyt commented Sep 28, 2025

hi @haideriqbal I started going down the road of adding some end-to-end tests but found that it was pretty inaccessible as an outside developer. Instead, I got the unit tests to work as part of the build, which can also be built with mvn clean test and are also now part of mvn clean package. This is more than sufficient to demonstrate that we have an understanding of what the code is doing and why.

However, it might be the case that improving the short form annotator invalidated other end-to-end tests, and I'm having a hard time seeing if that's the case since they don't give very pointed output (i.e., there's way too much logging, I can't see what is important)

@cthoyt cthoyt marked this pull request as ready for review September 28, 2025 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants