TP-Link: Space out HTTP requests a bit, retry connection for sending files #654
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
for the record, the initial idea i had is to cram both port triggers into one big command, so we only register one port trigger. however, that runs into character limits for the |
untitaker
force-pushed
the
tplink-v9-sleep
branch
from
12d5cf8 to
f98af21
Compare
…files On firmware M7350(EU)_V9_9.0.2 Build 241021 (but not sooner), entryId=2 was being sent before entryId=1. entryId=2 is invalid if entryId=1 does not exist yet. The reason it works is due to both requests firing simultaneously, so sometimes entryId=1 is indeed being registered first. We may also be hitting random race conditions on the backend, not 100% sure. Try to alleviate them by sleeping 1 second between started requests and waiting until the DOM is ready. Also, on sluggish devices, it can happen that nc is not ready within 100ms. Fixing that with exponential backoff.
untitaker
force-pushed
the
tplink-v9-sleep
branch
from
72a9aae to
8f42db5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
entryId=2
was being sent before entryId=1. entryId=2 is invalid if entryId=1 does
not exist yet. The reason it works is due to both requests firing
simultaneously, so sometimes entryId=1 is indeed being registered first.
EDIT: I couldn't find any actual validation for entryID in backend code, but I have observed weird glitches in JS when registering one before the other.
This bug was introduced in #609 and therefore, installers in version 0.7.0 and 0.7.1 are entirely broken for TP-Link hardware revisions greater than 3.0
We may also be hitting random race conditions on the backend, not 100%
sure. Try to alleviate them by sleeping 1 second between started
requests and waiting until the DOM is ready.
Also, on sluggish devices, it can happen that nc is not ready within
100ms. Fixing that with exponential backoff.