Skip to content

simplifying PublisherBase (passing all tests) #340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

simplifying PublisherBase (passing all tests) #340

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 3 additions & 26 deletions src/Elders.Cronus/PublisherBase.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,33 +45,10 @@ public static implicit operator bool(PublishResult result)
// The operation x && y is evaluated as PublishResult.false(x) ? x : PublishResult.&(x, y)
public static PublishResult operator &(PublishResult left, PublishResult right)
{
if (CanIgnoreLeft_isPublished(left, right))
{
if (left.isInitialState == false)
return new PublishResult(left.isHandlerExecuted && right.isHandlerExecuted, right.isPublished);

if (CanIgnoreLeft_isDelegatingHandlerExecuted(left, right))
return right;

return new PublishResult(left.isHandlerExecuted && right.isHandlerExecuted, right.isPublished);
}
else if (CanIgnoreLeft_isDelegatingHandlerExecuted(left, right))
{
return right;
}
if (left.isInitialState == false & left.isHandlerExecuted == false & left.isPublished == false & right.isHandlerExecuted & right.isPublished)
return new PublishResult(left.isHandlerExecuted & right.isHandlerExecuted, right.isPublished);

return new PublishResult(left.isHandlerExecuted && right.isHandlerExecuted, left.isPublished && right.isPublished);

///////////////
bool CanIgnoreLeft_isPublished(PublishResult left, PublishResult right)
{
return left.isPublished == false && right.isPublished == true;
}

bool CanIgnoreLeft_isDelegatingHandlerExecuted(PublishResult left, PublishResult right)
{
return left.isHandlerExecuted == false && right.isHandlerExecuted == true;
}
return right;
}
}

Expand Down