Skip to content

Conversation

stereokai
Copy link

@stereokai stereokai commented Aug 26, 2023

Hi @Ericbla, I forked your binary-parser-encoder fork and updated it by cherry picking all the commits from the original project that were missing here. I also got all current tests passing both for the parser and the encoder.

I'll be happy to commit for a little while to ensure your encoder project gets merged into binary-parser. As the original developer, your input and help in understanding your original motives and challenges would make a huge difference, so please let me know if you'd like to collaborate on this again :)

CC @keichi

keichi and others added 30 commits April 22, 2021 23:20
Added parsing context to `.readUntil()` and `.formatter()`
Added parsing context variables
Added missing semicolons on generated code
Fix wrong types
Disable context variables by default
wpyoga and others added 22 commits August 25, 2023 22:42
Bumps [socket.io-parser](https://github.com/socketio/socket.io-parser) from 4.0.4 to 4.0.5.
- [Release notes](https://github.com/socketio/socket.io-parser/releases)
- [Changelog](https://github.com/socketio/socket.io-parser/blob/main/CHANGELOG.md)
- [Commits](socketio/socket.io-parser@4.0.4...4.0.5)

---
updated-dependencies:
- dependency-name: socket.io-parser
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
Bumps [qs](https://github.com/ljharb/qs) and [body-parser](https://github.com/expressjs/body-parser). These dependencies needed to be updated together.

Updates `qs` from 6.7.0 to 6.11.0
- [Release notes](https://github.com/ljharb/qs/releases)
- [Changelog](https://github.com/ljharb/qs/blob/main/CHANGELOG.md)
- [Commits](ljharb/qs@v6.7.0...v6.11.0)

Updates `body-parser` from 1.19.0 to 1.20.1
- [Release notes](https://github.com/expressjs/body-parser/releases)
- [Changelog](https://github.com/expressjs/body-parser/blob/master/HISTORY.md)
- [Commits](expressjs/body-parser@1.19.0...1.20.1)

---
updated-dependencies:
- dependency-name: qs
  dependency-type: indirect
- dependency-name: body-parser
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
Bumps [minimatch](https://github.com/isaacs/minimatch) from 3.0.4 to 3.1.2.
- [Release notes](https://github.com/isaacs/minimatch/releases)
- [Changelog](https://github.com/isaacs/minimatch/blob/main/changelog.md)
- [Commits](isaacs/minimatch@v3.0.4...v3.1.2)

---
updated-dependencies:
- dependency-name: minimatch
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
Bumps [engine.io](https://github.com/socketio/engine.io) and [socket.io](https://github.com/socketio/socket.io). These dependencies needed to be updated together.

Updates `engine.io` from 6.1.2 to 6.2.1
- [Release notes](https://github.com/socketio/engine.io/releases)
- [Changelog](https://github.com/socketio/engine.io/blob/main/CHANGELOG.md)
- [Commits](socketio/engine.io@6.1.2...6.2.1)

Updates `socket.io` from 4.4.1 to 4.5.3
- [Release notes](https://github.com/socketio/socket.io/releases)
- [Changelog](https://github.com/socketio/socket.io/blob/main/CHANGELOG.md)
- [Commits](socketio/socket.io@4.4.1...4.5.3)

---
updated-dependencies:
- dependency-name: engine.io
  dependency-type: indirect
- dependency-name: socket.io
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
Bumps [json5](https://github.com/json5/json5) from 2.2.0 to 2.2.3.
- [Release notes](https://github.com/json5/json5/releases)
- [Changelog](https://github.com/json5/json5/blob/main/CHANGELOG.md)
- [Commits](json5/json5@v2.2.0...v2.2.3)

---
updated-dependencies:
- dependency-name: json5
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
Bumps [ua-parser-js](https://github.com/faisalman/ua-parser-js) from 0.7.31 to 0.7.33.
- [Release notes](https://github.com/faisalman/ua-parser-js/releases)
- [Changelog](https://github.com/faisalman/ua-parser-js/blob/master/changelog.md)
- [Commits](faisalman/ua-parser-js@0.7.31...0.7.33)

---
updated-dependencies:
- dependency-name: ua-parser-js
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
@Kreijstal
Copy link

@stereokai Thank you so much, thank you!

@kristian
Copy link

kristian commented Jan 30, 2025

@stereokai hope it is fine that I published a unmodified fork of your fork (I guess we are talking about a sub-sub-tine aka a „splinter“ at this point in time*) to NPM, I simply named it „binary-parser-encoder-bump“:

https://github.com/kristian/binary-parser

I wanted to base another one of my projects (that I am also planning on publishing) based on the parser / encoder version 2.2.1, so I needed the version on NPM. Please feel free to reach out, in case of any concerns! Thanks for your efforts. @Kreijstal, @keichi FYI.

* if the original fork of binary-parser to binary-parser-encoder was the fork, the fork of @Kreijstal was the tine, @stereokai yours was the sub-tine and mine is the sub-sub-tine, or a spliter of the original fork ;)

@stereokai
Copy link
Author

@kristian my pleasure.

This is hilarious. You could also say mine is the fork in the tine and yours is the tine on the fork in the tine 😁

Wonder if @Ericbla or @keichi will ever take a look at it.

@kristian
Copy link

kristian commented Jan 30, 2025

@stereokai

This is hilarious. You could also say mine is the fork in the tine and yours is the tine on the fork in the tine 😁

image

haha, nice! But joking aside, writing this summary:

This is a fork of Tom Alon's updated fork of Eric Blanchard's binary-parser-encoder fork adding encoding capabilities to the original binary-parser by Keichi Takahashi. Until the the encoding feature is merged in baseline of original project, this fork / branch is published under the name: binary-parser-encoder-bump on NPM.

… literally took more time than releasing the package to NPM, lol! In hopes of the original encoding feature gets merged into the upstream repository at some time, so the fork-ception can finally come to an end! ;) Cheers mate!

@Kreijstal
Copy link

Finally... an official fork

@Kreijstal
Copy link

@stereokai your fork doesn't have issues enabled

@stereokai
Copy link
Author

stereokai commented Jan 31, 2025

@Kreijstal opened

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.